ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-04-29 15:37:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix test logic: create offers with future expiration times, then advance ledger time

Browse Source 
Co-authored-by: mvadari <8029314+mvadari@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2025-08-21 13:51:49 +00:00
committed by Mayukha Vadari
parent 41bfa3819c
commit 858dc2b63b
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/test/app/NFToken_test.cpp
View File

@@ -6006,9 +6006,9 @@ class NFTokenBaseUtil_test : public beast::unit_test::suite
env(token::mint(issuer, 0), txflags(tfTransferable));
env.close();
// Create an offer with a short expiration time (already expired)
// Create an offer with a short expiration time
std::uint32_t const expiration =
lastClose(env) - 1; // 1 second ago
lastClose(env) + 2; // 2 seconds from now
uint256 const sellOfferIndex =
keylet::nftoffer(issuer, env.seq(issuer)).key;
@@ -6020,6 +6020,12 @@ class NFTokenBaseUtil_test : public beast::unit_test::suite
// Before: offer exists, owner count = 2 (NFT + offer)
BEAST_EXPECT(ownerCount(env, issuer) == 2);
// Advance time to make the offer expired
// Close ledgers to advance time past expiration
env.close();
env.close();
env.close();
// Try to accept the expired offer
env(token::acceptSellOffer(buyer, sellOfferIndex), ter(tecEXPIRED));
env.close();
@@ -6048,7 +6054,7 @@ class NFTokenBaseUtil_test : public beast::unit_test::suite
keylet::nftoffer(buyer, env.seq(buyer)).key;
env(token::createOffer(buyer, nftID, XRP(1)),
token::owner(issuer),
token::expiration(expiration)); // Also expired
token::expiration(expiration)); // Will also be expired after ledger advance
env.close();
// After creating buy offer, it should exist regardless of amendment