From 84c47bb55e6d53d77dba0da36ff2a1b091017cf4 Mon Sep 17 00:00:00 2001 From: Mayukha Vadari Date: Wed, 22 Jul 2026 18:54:59 -0400 Subject: [PATCH] fix clang-tidy issues --- include/xrpl/protocol/TER.h | 3 --- include/xrpl/tx/Transactor.h | 2 +- include/xrpl/tx/applySteps.h | 2 +- include/xrpl/tx/paths/detail/Steps.h | 2 +- src/libxrpl/tx/transactors/check/CheckCancel.cpp | 1 - .../tx/transactors/credentials/CredentialDelete.cpp | 1 - src/libxrpl/tx/transactors/delegate/DelegateSet.cpp | 1 - src/libxrpl/tx/transactors/dex/AMMDelete.cpp | 1 - src/libxrpl/tx/transactors/did/DIDDelete.cpp | 1 - src/libxrpl/tx/transactors/escrow/EscrowCancel.cpp | 1 - src/libxrpl/tx/transactors/escrow/EscrowFinish.cpp | 1 - src/libxrpl/tx/transactors/lending/LoanDelete.cpp | 1 - src/libxrpl/tx/transactors/lending/LoanManage.cpp | 1 + src/libxrpl/tx/transactors/oracle/OracleDelete.cpp | 2 +- .../permissioned_domain/PermissionedDomainDelete.cpp | 1 - src/libxrpl/tx/transactors/sponsor/SponsorshipSet.cpp | 1 - .../tx/transactors/sponsor/SponsorshipTransfer.cpp | 1 - .../tx/transactors/token/ConfidentialMPTConvert.cpp | 1 - .../transactors/token/ConfidentialMPTConvertBack.cpp | 1 - .../transactors/token/ConfidentialMPTMergeInbox.cpp | 1 - .../tx/transactors/token/ConfidentialMPTSend.cpp | 1 - src/libxrpl/tx/transactors/vault/VaultSet.cpp | 2 +- src/test/protocol/TER_test.cpp | 11 ++++++----- src/xrpld/app/misc/TxQ.h | 4 ++-- 24 files changed, 14 insertions(+), 30 deletions(-) diff --git a/include/xrpl/protocol/TER.h b/include/xrpl/protocol/TER.h index c50420b765..9513a0b907 100644 --- a/include/xrpl/protocol/TER.h +++ b/include/xrpl/protocol/TER.h @@ -834,9 +834,6 @@ transResultInfo(TERRaw code, std::string& token, std::string& text); std::string transToken(TERRaw code); -std::string -transHuman(TERRaw code); - std::optional transCode(std::string const& token); diff --git a/include/xrpl/tx/Transactor.h b/include/xrpl/tx/Transactor.h index a71285f70e..2de1f08af0 100644 --- a/include/xrpl/tx/Transactor.h +++ b/include/xrpl/tx/Transactor.h @@ -100,7 +100,7 @@ public: beast::Journal j = beast::Journal{beast::Journal::getNullSink()}) : registry(registry) , view(view) - , preflightResult(preflightResult) + , preflightResult(std::move(preflightResult)) , flags(flags) , tx(tx) , parentBatchId(parentBatchId) diff --git a/include/xrpl/tx/applySteps.h b/include/xrpl/tx/applySteps.h index bd495481f2..3be6c2b0bc 100644 --- a/include/xrpl/tx/applySteps.h +++ b/include/xrpl/tx/applySteps.h @@ -28,7 +28,7 @@ struct ApplyResult std::optional metadata; ApplyResult(TER t, bool a, std::optional m = std::nullopt) - : ter(t), applied(a), metadata(std::move(m)) + : ter(std::move(t)), applied(a), metadata(std::move(m)) { } }; diff --git a/include/xrpl/tx/paths/detail/Steps.h b/include/xrpl/tx/paths/detail/Steps.h index 8ee37c026c..b3269fa3d6 100644 --- a/include/xrpl/tx/paths/detail/Steps.h +++ b/include/xrpl/tx/paths/detail/Steps.h @@ -505,7 +505,7 @@ class FlowException : public std::runtime_error public: TER ter; - FlowException(TER t, std::string const& msg) : std::runtime_error(msg), ter(t) + FlowException(TER t, std::string const& msg) : std::runtime_error(msg), ter(std::move(t)) { } diff --git a/src/libxrpl/tx/transactors/check/CheckCancel.cpp b/src/libxrpl/tx/transactors/check/CheckCancel.cpp index 73622f2c77..ca0b5cafac 100644 --- a/src/libxrpl/tx/transactors/check/CheckCancel.cpp +++ b/src/libxrpl/tx/transactors/check/CheckCancel.cpp @@ -1,6 +1,5 @@ #include -#include #include #include #include diff --git a/src/libxrpl/tx/transactors/credentials/CredentialDelete.cpp b/src/libxrpl/tx/transactors/credentials/CredentialDelete.cpp index 2fc27a2b63..c6e2373784 100644 --- a/src/libxrpl/tx/transactors/credentials/CredentialDelete.cpp +++ b/src/libxrpl/tx/transactors/credentials/CredentialDelete.cpp @@ -1,6 +1,5 @@ #include -#include #include #include #include diff --git a/src/libxrpl/tx/transactors/delegate/DelegateSet.cpp b/src/libxrpl/tx/transactors/delegate/DelegateSet.cpp index ffc0527634..a718634f17 100644 --- a/src/libxrpl/tx/transactors/delegate/DelegateSet.cpp +++ b/src/libxrpl/tx/transactors/delegate/DelegateSet.cpp @@ -1,6 +1,5 @@ #include -#include #include #include #include diff --git a/src/libxrpl/tx/transactors/dex/AMMDelete.cpp b/src/libxrpl/tx/transactors/dex/AMMDelete.cpp index 1f318cb45d..82c3d93ea6 100644 --- a/src/libxrpl/tx/transactors/dex/AMMDelete.cpp +++ b/src/libxrpl/tx/transactors/dex/AMMDelete.cpp @@ -1,6 +1,5 @@ #include -#include #include #include #include diff --git a/src/libxrpl/tx/transactors/did/DIDDelete.cpp b/src/libxrpl/tx/transactors/did/DIDDelete.cpp index 5f103b3b90..d93ef928cb 100644 --- a/src/libxrpl/tx/transactors/did/DIDDelete.cpp +++ b/src/libxrpl/tx/transactors/did/DIDDelete.cpp @@ -1,6 +1,5 @@ #include -#include #include #include #include diff --git a/src/libxrpl/tx/transactors/escrow/EscrowCancel.cpp b/src/libxrpl/tx/transactors/escrow/EscrowCancel.cpp index ad3943a22d..9fbbb10ecb 100644 --- a/src/libxrpl/tx/transactors/escrow/EscrowCancel.cpp +++ b/src/libxrpl/tx/transactors/escrow/EscrowCancel.cpp @@ -1,6 +1,5 @@ #include -#include #include #include #include diff --git a/src/libxrpl/tx/transactors/escrow/EscrowFinish.cpp b/src/libxrpl/tx/transactors/escrow/EscrowFinish.cpp index 71dbc74b49..378c323ac9 100644 --- a/src/libxrpl/tx/transactors/escrow/EscrowFinish.cpp +++ b/src/libxrpl/tx/transactors/escrow/EscrowFinish.cpp @@ -1,6 +1,5 @@ #include -#include #include #include #include diff --git a/src/libxrpl/tx/transactors/lending/LoanDelete.cpp b/src/libxrpl/tx/transactors/lending/LoanDelete.cpp index 96d2993062..e060bfa136 100644 --- a/src/libxrpl/tx/transactors/lending/LoanDelete.cpp +++ b/src/libxrpl/tx/transactors/lending/LoanDelete.cpp @@ -1,6 +1,5 @@ #include -#include #include // IWYU pragma: keep #include #include diff --git a/src/libxrpl/tx/transactors/lending/LoanManage.cpp b/src/libxrpl/tx/transactors/lending/LoanManage.cpp index 3c14e457f4..6004b1c864 100644 --- a/src/libxrpl/tx/transactors/lending/LoanManage.cpp +++ b/src/libxrpl/tx/transactors/lending/LoanManage.cpp @@ -2,6 +2,7 @@ #include #include +#include #include #include #include diff --git a/src/libxrpl/tx/transactors/oracle/OracleDelete.cpp b/src/libxrpl/tx/transactors/oracle/OracleDelete.cpp index a8cc6f3691..270ea23173 100644 --- a/src/libxrpl/tx/transactors/oracle/OracleDelete.cpp +++ b/src/libxrpl/tx/transactors/oracle/OracleDelete.cpp @@ -1,6 +1,6 @@ #include -#include +#include #include #include #include diff --git a/src/libxrpl/tx/transactors/permissioned_domain/PermissionedDomainDelete.cpp b/src/libxrpl/tx/transactors/permissioned_domain/PermissionedDomainDelete.cpp index 8700b31e9b..81c3f5c5fc 100644 --- a/src/libxrpl/tx/transactors/permissioned_domain/PermissionedDomainDelete.cpp +++ b/src/libxrpl/tx/transactors/permissioned_domain/PermissionedDomainDelete.cpp @@ -1,6 +1,5 @@ #include -#include #include #include #include diff --git a/src/libxrpl/tx/transactors/sponsor/SponsorshipSet.cpp b/src/libxrpl/tx/transactors/sponsor/SponsorshipSet.cpp index 013ff0a95a..fb1bc417e7 100644 --- a/src/libxrpl/tx/transactors/sponsor/SponsorshipSet.cpp +++ b/src/libxrpl/tx/transactors/sponsor/SponsorshipSet.cpp @@ -1,6 +1,5 @@ #include -#include #include #include #include diff --git a/src/libxrpl/tx/transactors/sponsor/SponsorshipTransfer.cpp b/src/libxrpl/tx/transactors/sponsor/SponsorshipTransfer.cpp index 3d8716ba84..a6b5adc4e7 100644 --- a/src/libxrpl/tx/transactors/sponsor/SponsorshipTransfer.cpp +++ b/src/libxrpl/tx/transactors/sponsor/SponsorshipTransfer.cpp @@ -1,6 +1,5 @@ #include -#include #include #include #include diff --git a/src/libxrpl/tx/transactors/token/ConfidentialMPTConvert.cpp b/src/libxrpl/tx/transactors/token/ConfidentialMPTConvert.cpp index 485f8d15b6..3e0c30d183 100644 --- a/src/libxrpl/tx/transactors/token/ConfidentialMPTConvert.cpp +++ b/src/libxrpl/tx/transactors/token/ConfidentialMPTConvert.cpp @@ -1,6 +1,5 @@ #include -#include #include #include #include diff --git a/src/libxrpl/tx/transactors/token/ConfidentialMPTConvertBack.cpp b/src/libxrpl/tx/transactors/token/ConfidentialMPTConvertBack.cpp index 538184724b..a470250981 100644 --- a/src/libxrpl/tx/transactors/token/ConfidentialMPTConvertBack.cpp +++ b/src/libxrpl/tx/transactors/token/ConfidentialMPTConvertBack.cpp @@ -1,6 +1,5 @@ #include -#include #include #include #include diff --git a/src/libxrpl/tx/transactors/token/ConfidentialMPTMergeInbox.cpp b/src/libxrpl/tx/transactors/token/ConfidentialMPTMergeInbox.cpp index 310a08ed9c..7a94c3e9b7 100644 --- a/src/libxrpl/tx/transactors/token/ConfidentialMPTMergeInbox.cpp +++ b/src/libxrpl/tx/transactors/token/ConfidentialMPTMergeInbox.cpp @@ -1,6 +1,5 @@ #include -#include #include #include #include diff --git a/src/libxrpl/tx/transactors/token/ConfidentialMPTSend.cpp b/src/libxrpl/tx/transactors/token/ConfidentialMPTSend.cpp index 1381f6f846..db904c1c60 100644 --- a/src/libxrpl/tx/transactors/token/ConfidentialMPTSend.cpp +++ b/src/libxrpl/tx/transactors/token/ConfidentialMPTSend.cpp @@ -1,6 +1,5 @@ #include -#include #include #include #include diff --git a/src/libxrpl/tx/transactors/vault/VaultSet.cpp b/src/libxrpl/tx/transactors/vault/VaultSet.cpp index e2d7d38859..1df6f2d1d4 100644 --- a/src/libxrpl/tx/transactors/vault/VaultSet.cpp +++ b/src/libxrpl/tx/transactors/vault/VaultSet.cpp @@ -1,6 +1,6 @@ #include -#include +#include #include #include #include diff --git a/src/test/protocol/TER_test.cpp b/src/test/protocol/TER_test.cpp index e7c18f1f2c..c956ac94c3 100644 --- a/src/test/protocol/TER_test.cpp +++ b/src/test/protocol/TER_test.cpp @@ -5,6 +5,7 @@ #include #include #include +#include namespace xrpl { @@ -242,21 +243,21 @@ struct TER_test : public beast::unit_test::Suite // 1. Implicit conversion from enum uses transHuman { - TER t = tecNO_DST; + TER const t = tecNO_DST; BEAST_EXPECT(t.code == tecNO_DST); BEAST_EXPECT(t.reason == transHuman(TERRaw{tecNO_DST})); } // 2. Explicit reason { - TER t = {tecNO_DST, "custom reason"}; + TER const t = {tecNO_DST, "custom reason"}; BEAST_EXPECT(t.code == tecNO_DST); BEAST_EXPECT(t.reason == "custom reason"); } // 3. Default constructor uses tesSUCCESS description { - TER t; + TER const t; BEAST_EXPECT(t.code == tesSUCCESS); BEAST_EXPECT(t.reason == transHuman(TERRaw{tesSUCCESS})); } @@ -264,11 +265,11 @@ struct TER_test : public beast::unit_test::Suite // 4. Copy and move { TER t1 = {tecPATH_DRY, "reason 1"}; - TER t2 = t1; + TER const t2 = t1; BEAST_EXPECT(t2.code == tecPATH_DRY); BEAST_EXPECT(t2.reason == "reason 1"); - TER t3 = std::move(t1); + TER const t3 = std::move(t1); BEAST_EXPECT(t3.code == tecPATH_DRY); BEAST_EXPECT(t3.reason == "reason 1"); } diff --git a/src/xrpld/app/misc/TxQ.h b/src/xrpld/app/misc/TxQ.h index 65b4e9778c..71a653df92 100644 --- a/src/xrpld/app/misc/TxQ.h +++ b/src/xrpld/app/misc/TxQ.h @@ -251,8 +251,8 @@ public: , seqProxy(seqProxy) , txn(txn) , retriesRemaining(retriesRemaining) - , preflightResult(preflightResult) - , lastResult(lastResult) + , preflightResult(std::move(preflightResult)) + , lastResult(std::move(lastResult)) { }