ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Use consistent CMake settings for all modules (#5228)

Browse Source 
* Resolves an issue introduced in #5111, which inadvertently removed the
  -Wno-maybe-uninitialized compiler option from some xrpl.libxrpl
  modules. This resulted in new "may be used uninitialized" build
  warnings, first noticed in the "protocol" module. When compiling with
  derr=TRUE, those warnings became errors, which made the build fail.
* Github CI actions will build with the assert and werr options turned
  on. This will cause CI jobs to fail if a developer introduces a new
  compiler warning, or causes an assert to fail in release builds.
* Includes the OS and compiler version in the linux dependencies jobs in
  the "check environment" step.
* Translates the `unity` build option into `CMAKE_UNITY_BUILD` setting.
This commit is contained in:
Ed Hennis
2025-01-16 16:10:30 -05:00
committed by GitHub
parent 7be5c31bc6
commit 839d17e7bd
6 changed files with 18 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/xrpld/app/paths/detail/DirectStep.cpp
View File

@@ -336,7 +336,7 @@ DirectIPaymentStep::quality(ReadView const& sb, QualityDirection qDir) const
if (!sle)
return QUALITY_ONE;
auto const& field = [this, qDir]() -> SF_UINT32 const& {
auto const& field = [&, this]() -> SF_UINT32 const& {
if (qDir == QualityDirection::in)
{
// compute dst quality in