From 6f403fdd1b9fb936bf0703fe75ce7149effb5a96 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Thu, 14 May 2026 13:58:13 +0100 Subject: [PATCH 1/2] fix(telemetry): align Tempo search tags with C++ span attribute names RPC span attributes use bare names (command, rpc_status, rpc_role) per the naming convention in SpanNames.h, not xrpl.rpc.* qualified names. Node health attributes (amendment_blocked, server_state) are resource attributes set at Tracer init, not span attributes. Co-Authored-By: Claude Opus 4.6 (1M context) --- .../grafana/provisioning/datasources/tempo.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/docker/telemetry/grafana/provisioning/datasources/tempo.yaml b/docker/telemetry/grafana/provisioning/datasources/tempo.yaml index 198c2550d3..7f4bd3684f 100644 --- a/docker/telemetry/grafana/provisioning/datasources/tempo.yaml +++ b/docker/telemetry/grafana/provisioning/datasources/tempo.yaml @@ -92,28 +92,28 @@ datasources: type: static # Phase 2: RPC tracing filters - id: rpc-command - tag: xrpl.rpc.command + tag: command operator: "=" scope: span type: static - id: rpc-status - tag: xrpl.rpc.status + tag: rpc_status operator: "=" scope: span type: dynamic - id: rpc-role - tag: xrpl.rpc.role + tag: rpc_role operator: "=" scope: span type: dynamic - # Phase 2: Node health filters (Task 2.8) + # Phase 2: Node health filters (Task 2.8) — resource attributes - id: node-amendment-blocked tag: xrpl.node.amendment_blocked operator: "=" - scope: span + scope: resource type: static - id: node-server-state tag: xrpl.node.server_state operator: "=" - scope: span + scope: resource type: dynamic From b3920355444269410a800a513b13b7fab141f6e7 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Thu, 14 May 2026 13:58:31 +0100 Subject: [PATCH 2/2] fix(telemetry): align Tempo TX search tags with C++ attribute names Transaction span attributes use bare names (local, tx_status) per SpanNames.h convention, not xrpl.tx.* qualified names. xrpl.tx.hash is correct (shared canonical attr defined in SpanNames.h). Co-Authored-By: Claude Opus 4.6 (1M context) --- docker/telemetry/grafana/provisioning/datasources/tempo.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docker/telemetry/grafana/provisioning/datasources/tempo.yaml b/docker/telemetry/grafana/provisioning/datasources/tempo.yaml index 7f1265bf28..542d7ddb7d 100644 --- a/docker/telemetry/grafana/provisioning/datasources/tempo.yaml +++ b/docker/telemetry/grafana/provisioning/datasources/tempo.yaml @@ -125,12 +125,12 @@ datasources: scope: span type: static - id: tx-origin - tag: xrpl.tx.local + tag: local operator: "=" scope: span type: dynamic - id: tx-status - tag: xrpl.tx.status + tag: tx_status operator: "=" scope: span type: dynamic