diff --git a/modules/ripple_basics/ripple_basics.h b/modules/ripple_basics/ripple_basics.h index 5103a4d425..7e2295c1a3 100644 --- a/modules/ripple_basics/ripple_basics.h +++ b/modules/ripple_basics/ripple_basics.h @@ -84,6 +84,12 @@ namespace boost { // RippleTime #include +// ScopedLock +//#include +//#include +//#include +//#include + // ByteOrder #ifdef WIN32 // (nothing) @@ -122,6 +128,7 @@ namespace boost { #include "utility/ripple_DiffieHellmanUtil.h" #include "utility/ripple_PlatformMacros.h" #include "utility/ripple_RandomNumbers.h" +#include "utility/ripple_ScopedLock.h" #include "utility/ripple_StringUtilities.h" #include "utility/ripple_Sustain.h" #include "utility/ripple_ThreadName.h" diff --git a/src/cpp/ripple/ScopedLock.h b/modules/ripple_basics/utility/ripple_ScopedLock.h similarity index 85% rename from src/cpp/ripple/ScopedLock.h rename to modules/ripple_basics/utility/ripple_ScopedLock.h index e1a1fe9225..3974577dbc 100644 --- a/src/cpp/ripple/ScopedLock.h +++ b/modules/ripple_basics/utility/ripple_ScopedLock.h @@ -1,16 +1,13 @@ -#ifndef __SCOPEDLOCKHOLDER__ -#define __SCOPEDLOCKHOLDER__ - -#include -#include -#include -#include +#ifndef RIPPLE_SCOPEDLOCK_H +#define RIPPLE_SCOPEDLOCK_H typedef boost::recursive_mutex::scoped_lock ScopedLock; // A lock holder that can be returned and copied by value // When the last reference goes away, the lock is released +// VFALCO: TODO, replace these with a more generic template, and not use boost +// class SharedScopedLock { protected: @@ -33,6 +30,7 @@ protected: boost::recursive_mutex& mMutex; public: + // VFALCO: TODO, get rid of this unlock parameter to restore sanity ScopedUnlock(boost::recursive_mutex& mutex, bool unlock = true) : mUnlocked(unlock), mMutex(mutex) { if (unlock) diff --git a/newcoin.vcxproj b/newcoin.vcxproj index 7675556480..9f10977e35 100644 --- a/newcoin.vcxproj +++ b/newcoin.vcxproj @@ -1239,6 +1239,7 @@ + @@ -1639,7 +1640,6 @@ - diff --git a/newcoin.vcxproj.filters b/newcoin.vcxproj.filters index 87d677b97e..7c13776ee1 100644 --- a/newcoin.vcxproj.filters +++ b/newcoin.vcxproj.filters @@ -1295,9 +1295,6 @@ 1. Modules\ripple_mess\containers - - 1. Modules\ripple_mess\types - 1. Modules\ripple_main\_old @@ -1460,6 +1457,9 @@ 1. Modules\ripple_data\types + + 1. Modules\ripple_basics\utility + diff --git a/src/cpp/ripple/Application.h b/src/cpp/ripple/Application.h index c3acee7f44..e05126e59a 100644 --- a/src/cpp/ripple/Application.h +++ b/src/cpp/ripple/Application.h @@ -13,7 +13,6 @@ #include "UniqueNodeList.h" #include "ConnectionPool.h" #include "FeatureTable.h" -#include "ScopedLock.h" #include "LedgerAcquire.h" #include "TransactionMaster.h" #include "Wallet.h" diff --git a/src/cpp/ripple/HashedObject.h b/src/cpp/ripple/HashedObject.h index f85a66ca6a..abe024039d 100644 --- a/src/cpp/ripple/HashedObject.h +++ b/src/cpp/ripple/HashedObject.h @@ -8,7 +8,6 @@ #include "modules/ripple_main/misc/ripple_HashValue.h" -#include "ScopedLock.h" #include "InstanceCounter.h" diff --git a/src/cpp/ripple/RPCHandler.h b/src/cpp/ripple/RPCHandler.h index ef92b71d15..298d76c605 100644 --- a/src/cpp/ripple/RPCHandler.h +++ b/src/cpp/ripple/RPCHandler.h @@ -6,7 +6,6 @@ #include "SerializedTypes.h" #include "Ledger.h" #include "NetworkOPs.h" -#include "ScopedLock.h" #define LEDGER_CURRENT -1 #define LEDGER_CLOSED -2 diff --git a/src/cpp/ripple/SHAMap.h b/src/cpp/ripple/SHAMap.h index 76d8f418a6..e3b62f80b1 100644 --- a/src/cpp/ripple/SHAMap.h +++ b/src/cpp/ripple/SHAMap.h @@ -9,7 +9,6 @@ #include #include -#include "ScopedLock.h" #include "HashedObject.h" #include "InstanceCounter.h"