ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-01 16:35:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

test: Check for some unlikely null dereferences in tests (#5004)

Browse Source
This commit is contained in:
Ed Hennis
2024-12-03 15:03:22 -05:00
parent d7e949193f
commit 8215c605b4
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/test/jtx/impl/flags.cpp
View File

@@ -41,7 +41,9 @@ void
flags::operator()(Env& env) const flags::operator()(Env& env) const
{ {
auto const sle = env.le(account_); auto const sle = env.le(account_);
if (sle->isFieldPresent(sfFlags)) if (!sle)
env.test.fail();
else if (sle->isFieldPresent(sfFlags))
env.test.expect((sle->getFieldU32(sfFlags) & mask_) == mask_); env.test.expect((sle->getFieldU32(sfFlags) & mask_) == mask_);
else else
env.test.expect(mask_ == 0); env.test.expect(mask_ == 0);
@@ -51,7 +53,9 @@ void
nflags::operator()(Env& env) const nflags::operator()(Env& env) const
{ {
auto const sle = env.le(account_); auto const sle = env.le(account_);
if (sle->isFieldPresent(sfFlags)) if (!sle)
env.test.fail();
else if (sle->isFieldPresent(sfFlags))
env.test.expect((sle->getFieldU32(sfFlags) & mask_) == 0); env.test.expect((sle->getFieldU32(sfFlags) & mask_) == 0);
else else
env.test.pass(); env.test.pass();

2
src/test/rpc/AccountSet_test.cpp
View File

@@ -41,7 +41,7 @@ public:
env.fund(XRP(10000), noripple(alice)); env.fund(XRP(10000), noripple(alice));
// ask for the ledger entry - account root, to check its flags // ask for the ledger entry - account root, to check its flags
auto const jrr = env.le(alice); auto const jrr = env.le(alice);
BEAST_EXPECT((*env.le(alice))[sfFlags] == 0u); BEAST_EXPECT(jrr && jrr->at(sfFlags) == 0u);
} }
void void