From 2f61ce6851599f78fbe4ab3d1bde522cd2426138 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Fri, 18 Sep 2026 10:06:36 +0100 Subject: [PATCH] docs(telemetry): match the task list to where the receive span now starts The steps described setting a suppressed attribute on a dropped duplicate, in the pre-rename dotted spelling. The span is now created after the duplicate check, so there is no span on that path in either spelling. --- OpenTelemetryPlan/Phase3_taskList.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/OpenTelemetryPlan/Phase3_taskList.md b/OpenTelemetryPlan/Phase3_taskList.md index f21f00f0ed..a1f996bd8b 100644 --- a/OpenTelemetryPlan/Phase3_taskList.md +++ b/OpenTelemetryPlan/Phase3_taskList.md @@ -97,7 +97,7 @@ - Extract parent trace context from incoming `TMTransaction::trace_context` field (if present) - Create `tx.receive` span as child of extracted context (or new root if none) - Set attributes: `xrpl.tx.hash`, `xrpl.peer.id`, `xrpl.tx.status` - - On HashRouter suppression (duplicate): set `xrpl.tx.suppressed=true`, add `tx.duplicate` event + - Create the span only after `HashRouter::shouldProcess()` accepts, so a dropped duplicate produces no span - Wrap validation call with child span `tx.validate` - Wrap relay with `tx.relay` span - When relaying to peers: @@ -158,7 +158,7 @@ - Edit `src/xrpld/overlay/detail/PeerImp.cpp` (in handleTransaction): - After calling `HashRouter::shouldProcess()` or `addSuppressionPeer()`: - - Record `xrpl.tx.suppressed` attribute (true/false) + - Start the span here, not before, so only transactions this node will process are traced - Record `xrpl.tx.flags` showing current HashRouter state (SAVED, TRUSTED, etc.) - Add `tx.first_seen` or `tx.duplicate` event