ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Computing our node public and private keys every time we needed them was silly and expensive.

Browse Source
This commit is contained in:
JoelKatz
2012-10-25 18:59:07 -07:00
parent 87df08ea0b
commit 7f44d1569e
10 changed files with 38 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/SerializedValidation.cpp
View File

@@ -37,25 +37,22 @@ SerializedValidation::SerializedValidation(SerializerIterator& sit, bool checkSi
}
SerializedValidation::SerializedValidation(const uint256& ledgerHash, uint32 signTime,
const RippleAddress& naSeed, bool isFull, uint256& signingHash)
const RippleAddress& naPub, const RippleAddress& naPriv, bool isFull, uint256& signingHash)
: STObject(sValidationFormat, sfValidation), mTrusted(false)
{
setFieldH256(sfLedgerHash, ledgerHash);
setFieldU32(sfSigningTime, signTime);
if (naSeed.isValid())
{ // OPTIMIZEME: Should compute the node public key just once and pass it in
RippleAddress np = RippleAddress::createNodePublic(naSeed);
setFieldVL(sfSigningPubKey, np.getNodePublic());
mNodeID = np.getNodeID();
assert(mNodeID.isNonZero());
}
setFieldVL(sfSigningPubKey, naPub.getNodePublic());
mNodeID = naPub.getNodeID();
assert(mNodeID.isNonZero());
if (!isFull)
setFlag(sFullFlag);
signingHash = getSigningHash();
std::vector<unsigned char> signature;
// OPTIMIZEME: Should compute the node private key just once and pass it in
RippleAddress::createNodePrivate(naSeed).signNodePrivate(signingHash, signature);
naPriv.signNodePrivate(signingHash, signature);
setFieldVL(sfSignature, signature);
// XXX Check if this can fail.
// if (!RippleAddress::createNodePrivate(naSeed).signNodePrivate(getSigningHash(), mSignature.peekValue()))