ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename LedgerAcquire to InboundLedger

Browse Source
This commit is contained in:
Vinnie Falco
2013-06-16 08:40:39 -07:00
parent 326ff5a205
commit 7eff38c1bb
22 changed files with 238 additions and 198 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
RefactoringNotes.txt
View File

@@ -10,6 +10,8 @@ TODO
- Replace uint160, uint256 in argument lists, template parameter lists, and
data members with tyepdefs from ripple_ProtocolTypes.h
- Consolidate SQLite database classes: DatabaseCon, Database, SqliteDatabase.
--------------------------------------------------------------------------------
LoadEvent
@@ -27,11 +29,15 @@ Naming
Some names don't make sense.
LedgerAcquire
InboundLedger
Not a noun.
Is it really an InboundLedger ?
Does it continue to exist after the ledger is received?
Index
Stop using Index to refer to keys in tables.
Index implies a small integer, or a data structure.
Inconsistent names
We have full names like SerializedType and then acronyms like STObject