ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-07-24 15:40:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Fix tests for clang-tidy bugprone-unchecked-optional-access check (#6502)

Browse Source
This commit is contained in:
Alex Kremer
2026-03-16 23:47:40 +00:00
committed by GitHub
parent ffea3977f0
commit 7e7b71d84c
55 changed files with 495 additions and 150 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/test/protocol/SecretKey_test.cpp
View File

@@ -72,12 +72,16 @@ public:
{
auto const canonicality = ecdsaCanonicality(makeSlice(sig));
BEAST_EXPECT(canonicality);
// NOLINTNEXTLINE(bugprone-unchecked-optional-access)
BEAST_EXPECT(*canonicality == ECDSACanonicality::fullyCanonical);
}
{
auto const canonicality = ecdsaCanonicality(makeSlice(non));
BEAST_EXPECT(canonicality);
// NOLINTNEXTLINE(bugprone-unchecked-optional-access)
BEAST_EXPECT(*canonicality != ECDSACanonicality::fullyCanonical);
}
@@ -97,6 +101,8 @@ public:
auto const [pk, sk] = randomKeyPair(KeyType::secp256k1);
BEAST_EXPECT(pk == derivePublicKey(KeyType::secp256k1, sk));
// NOLINTNEXTLINE(bugprone-unchecked-optional-access)
BEAST_EXPECT(*publicKeyType(pk) == KeyType::secp256k1);
for (std::size_t j = 0; j < 32; j++)
@@ -135,7 +141,7 @@ public:
auto const [pk, sk] = randomKeyPair(type);
BEAST_EXPECT(pk == derivePublicKey(type, sk));
BEAST_EXPECT(*publicKeyType(pk) == type);
BEAST_EXPECT(*publicKeyType(pk) == type); // NOLINT(bugprone-unchecked-optional-access)
for (std::size_t j = 0; j < 32; j++)
{
@@ -185,7 +191,7 @@ public:
TokenType::NodePrivate, "pnen77YEeUd4fFKG7iycBWcwKpTaeFRkW2WFostaATy1DSupwXe");
BEAST_EXPECT(sk2);
BEAST_EXPECT(test::equal(sk1, *sk2));
BEAST_EXPECT(test::equal(sk1, *sk2)); // NOLINT(bugprone-unchecked-optional-access)
}
{
@@ -195,7 +201,7 @@ public:
TokenType::NodePrivate, "paKv46LztLqK3GaKz1rG2nQGN6M4JLyRtxFBYFTw4wAVHtGys36");
BEAST_EXPECT(sk2);
BEAST_EXPECT(test::equal(sk1, *sk2));
BEAST_EXPECT(test::equal(sk1, *sk2)); // NOLINT(bugprone-unchecked-optional-access)
}
// Try converting short, long and malformed data
@@ -276,6 +282,7 @@ public:
auto const skj = parseBase58<SecretKey>(TokenType::NodePrivate, sj);
BEAST_EXPECT(skj && test::equal(keys[j], *skj));
// NOLINTNEXTLINE(bugprone-unchecked-optional-access)
BEAST_EXPECT(test::equal(*ski, *skj) == (i == j));
}
}
@@ -295,7 +302,8 @@ public:
BEAST_EXPECT(kp.first == PublicKey{makeSlice(test.pubkey)});
BEAST_EXPECT(test::equal(kp.second, SecretKey{makeSlice(test.seckey)}));
BEAST_EXPECT(calcAccountID(kp.first) == *id);
BEAST_EXPECT(
calcAccountID(kp.first) == *id); // NOLINT(bugprone-unchecked-optional-access)
}
}
@@ -313,7 +321,8 @@ public:
BEAST_EXPECT(kp.first == PublicKey{makeSlice(test.pubkey)});
BEAST_EXPECT(test::equal(kp.second, SecretKey{makeSlice(test.seckey)}));
BEAST_EXPECT(calcAccountID(kp.first) == *id);
BEAST_EXPECT(
calcAccountID(kp.first) == *id); // NOLINT(bugprone-unchecked-optional-access)
}
}