ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-08-23 15:20:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Fix tests for clang-tidy bugprone-unchecked-optional-access check (#6502)

Browse Source
This commit is contained in:
Alex Kremer
2026-03-16 23:47:40 +00:00
committed by GitHub
parent ffea3977f0
commit 7e7b71d84c
55 changed files with 495 additions and 150 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/test/overlay/cluster_test.cpp
View File

@@ -121,7 +121,7 @@ public:
{
auto member = c->member(node);
BEAST_EXPECT(static_cast<bool>(member));
BEAST_EXPECT(member->empty());
BEAST_EXPECT(member->empty()); // NOLINT(bugprone-unchecked-optional-access)
}
// Updating too quickly: should fail
@@ -129,7 +129,7 @@ public:
{
auto member = c->member(node);
BEAST_EXPECT(static_cast<bool>(member));
BEAST_EXPECT(member->empty());
BEAST_EXPECT(member->empty()); // NOLINT(bugprone-unchecked-optional-access)
}
using namespace std::chrono_literals;
@@ -140,7 +140,7 @@ public:
{
auto member = c->member(node);
BEAST_EXPECT(static_cast<bool>(member));
BEAST_EXPECT(member->compare(name) == 0);
BEAST_EXPECT(member->compare(name) == 0); // NOLINT(bugprone-unchecked-optional-access)
}
// Updating the name (non-empty doesn't go to empty)
@@ -149,7 +149,7 @@ public:
{
auto member = c->member(node);
BEAST_EXPECT(static_cast<bool>(member));
BEAST_EXPECT(member->compare(name) == 0);
BEAST_EXPECT(member->compare(name) == 0); // NOLINT(bugprone-unchecked-optional-access)
}
// Updating the name (non-empty updates to new non-empty)
@@ -158,7 +158,8 @@ public:
{
auto member = c->member(node);
BEAST_EXPECT(static_cast<bool>(member));
BEAST_EXPECT(member->compare("test") == 0);
BEAST_EXPECT(
member->compare("test") == 0); // NOLINT(bugprone-unchecked-optional-access)
}
}