ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-06-03 16:56:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Fix tests for clang-tidy bugprone-unchecked-optional-access check (#6502)

Browse Source
This commit is contained in:
Alex Kremer
2026-03-16 23:47:40 +00:00
committed by GitHub
parent ffea3977f0
commit 7e7b71d84c
55 changed files with 495 additions and 150 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/test/basics/StringUtilities_test.cpp
View File

@@ -13,6 +13,8 @@ public:
{
auto rv = strUnHex(strIn);
BEAST_EXPECT(rv);
// NOLINTNEXTLINE(bugprone-unchecked-optional-access)
BEAST_EXPECT(makeSlice(*rv) == makeSlice(strExpected));
}
@@ -92,7 +94,7 @@ public:
BEAST_EXPECT(pUrl.username.empty());
BEAST_EXPECT(pUrl.password.empty());
BEAST_EXPECT(pUrl.domain == "domain");
BEAST_EXPECT(*pUrl.port == 234);
BEAST_EXPECT(*pUrl.port == 234); // NOLINT(bugprone-unchecked-optional-access)
BEAST_EXPECT(pUrl.path == "/");
}
@@ -114,7 +116,7 @@ public:
BEAST_EXPECT(pUrl.username.empty());
BEAST_EXPECT(pUrl.password.empty());
BEAST_EXPECT(pUrl.domain == "::1");
BEAST_EXPECT(*pUrl.port == 123);
BEAST_EXPECT(*pUrl.port == 123); // NOLINT(bugprone-unchecked-optional-access)
BEAST_EXPECT(pUrl.path == "/path");
}
@@ -125,7 +127,7 @@ public:
BEAST_EXPECT(pUrl.username == "user");
BEAST_EXPECT(pUrl.password == "pass");
BEAST_EXPECT(pUrl.domain == "domain");
BEAST_EXPECT(*pUrl.port == 123);
BEAST_EXPECT(*pUrl.port == 123); // NOLINT(bugprone-unchecked-optional-access)
BEAST_EXPECT(pUrl.path == "/abc:321");
}
@@ -136,7 +138,7 @@ public:
BEAST_EXPECT(pUrl.username == "user");
BEAST_EXPECT(pUrl.password.empty());
BEAST_EXPECT(pUrl.domain == "domain");
BEAST_EXPECT(*pUrl.port == 123);
BEAST_EXPECT(*pUrl.port == 123); // NOLINT(bugprone-unchecked-optional-access)
BEAST_EXPECT(pUrl.path == "/abc:321");
}
@@ -147,7 +149,7 @@ public:
BEAST_EXPECT(pUrl.username.empty());
BEAST_EXPECT(pUrl.password == "pass");
BEAST_EXPECT(pUrl.domain == "domain");
BEAST_EXPECT(*pUrl.port == 123);
BEAST_EXPECT(*pUrl.port == 123); // NOLINT(bugprone-unchecked-optional-access)
BEAST_EXPECT(pUrl.path == "/abc:321");
}
@@ -158,7 +160,7 @@ public:
BEAST_EXPECT(pUrl.username.empty());
BEAST_EXPECT(pUrl.password.empty());
BEAST_EXPECT(pUrl.domain == "domain");
BEAST_EXPECT(*pUrl.port == 123);
BEAST_EXPECT(*pUrl.port == 123); // NOLINT(bugprone-unchecked-optional-access)
BEAST_EXPECT(pUrl.path == "/abc:321");
}