ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-04-29 15:37:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Fix tests for clang-tidy bugprone-unchecked-optional-access check (#6502)

Browse Source
This commit is contained in:
Alex Kremer
2026-03-16 23:47:40 +00:00
committed by GitHub
parent ffea3977f0
commit 7e7b71d84c
55 changed files with 495 additions and 150 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/test/app/ValidatorKeys_test.cpp
View File

@@ -63,17 +63,21 @@ public:
// Keys/ID when using [validation_seed]
SecretKey const seedSecretKey =
// NOLINTNEXTLINE(bugprone-unchecked-optional-access)
generateSecretKey(KeyType::secp256k1, *parseBase58<Seed>(seed));
PublicKey const seedPublicKey = derivePublicKey(KeyType::secp256k1, seedSecretKey);
NodeID const seedNodeID = calcNodeID(seedPublicKey);
// Keys when using [validation_token]
// NOLINTNEXTLINE(bugprone-unchecked-optional-access)
auto const tokenSecretKey = *parseBase58<SecretKey>(TokenType::NodePrivate, tokenSecretStr);
auto const tokenPublicKey = derivePublicKey(KeyType::secp256k1, tokenSecretKey);
auto const m = deserializeManifest(base64_decode(tokenManifest));
BEAST_EXPECT(m);
// NOLINTNEXTLINE(bugprone-unchecked-optional-access)
NodeID const tokenNodeID = calcNodeID(m->masterKey);
{
@@ -90,7 +94,7 @@ public:
c.section(SECTION_VALIDATION_SEED).append(seed);
ValidatorKeys k{c, journal};
if (BEAST_EXPECT(k.keys))
if (BEAST_EXPECT(k.keys); k.keys.has_value())
{
BEAST_EXPECT(k.keys->publicKey == seedPublicKey);
BEAST_EXPECT(test::equal(k.keys->secretKey, seedSecretKey));
@@ -117,7 +121,7 @@ public:
c.section(SECTION_VALIDATOR_TOKEN).append(tokenBlob);
ValidatorKeys k{c, journal};
if (BEAST_EXPECT(k.keys))
if (BEAST_EXPECT(k.keys); k.keys.has_value())
{
BEAST_EXPECT(k.keys->publicKey == tokenPublicKey);
BEAST_EXPECT(test::equal(k.keys->secretKey, tokenSecretKey));