ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-08-22 23:00:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Compute validation suppression key over canonical serialisation

Browse Source
This commit is contained in:
Jingchen
2026-07-17 12:33:44 +01:00
committed by Ayaz Salikhov
parent 7877ee42a0
commit 7d3611df2a
5 changed files with 95 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
src/test/protocol/STValidation_test.cpp
View File

@@ -153,7 +153,10 @@ public:
SerialIter sit{kPayload8};
auto val = std::make_shared<STValidation>(
sit, [](PublicKey const& pk) { return calcNodeID(pk); }, true);
sit,
[](PublicKey const& pk) { return calcNodeID(pk); },
STValidation::DeserializeOptions{
.checkSignature = true, .requireCanonicalOrder = false});
BEAST_EXPECT(val);
BEAST_EXPECT(val->isFieldPresent(sfLedgerSequence));
@@ -174,7 +177,10 @@ public:
{
SerialIter sit{kPayload1};
auto val = std::make_shared<xrpl::STValidation>(
sit, [](PublicKey const& pk) { return calcNodeID(pk); }, false);
sit,
[](PublicKey const& pk) { return calcNodeID(pk); },
STValidation::DeserializeOptions{
.checkSignature = false, .requireCanonicalOrder = false});
fail("An exception should have been thrown");
}
catch (std::exception const& ex)
@@ -186,7 +192,10 @@ public:
{
SerialIter sit{kPayload2};
auto val = std::make_shared<xrpl::STValidation>(
sit, [](PublicKey const& pk) { return calcNodeID(pk); }, false);
sit,
[](PublicKey const& pk) { return calcNodeID(pk); },
STValidation::DeserializeOptions{
.checkSignature = false, .requireCanonicalOrder = false});
fail("An exception should have been thrown");
}
catch (std::exception const& ex)
@@ -198,7 +207,10 @@ public:
{
SerialIter sit{kPayload3};
auto val = std::make_shared<xrpl::STValidation>(
sit, [](PublicKey const& pk) { return calcNodeID(pk); }, false);
sit,
[](PublicKey const& pk) { return calcNodeID(pk); },
STValidation::DeserializeOptions{
.checkSignature = false, .requireCanonicalOrder = false});
fail("An exception should have been thrown");
}
catch (std::exception const& ex)
@@ -210,7 +222,10 @@ public:
{
SerialIter sit{kPayload4};
auto val = std::make_shared<xrpl::STValidation>(
sit, [](PublicKey const& pk) { return calcNodeID(pk); }, false);
sit,
[](PublicKey const& pk) { return calcNodeID(pk); },
STValidation::DeserializeOptions{
.checkSignature = false, .requireCanonicalOrder = false});
fail("An exception should have been thrown");
}
catch (std::exception const& ex)
@@ -224,7 +239,10 @@ public:
{
SerialIter sit{kPayload5};
auto val = std::make_shared<STValidation>(
sit, [](PublicKey const& pk) { return calcNodeID(pk); }, false);
sit,
[](PublicKey const& pk) { return calcNodeID(pk); },
STValidation::DeserializeOptions{
.checkSignature = false, .requireCanonicalOrder = false});
fail("Expected exception not thrown from validation");
}
catch (std::exception const& ex)
@@ -236,7 +254,10 @@ public:
{
SerialIter sit{kPayload6};
auto val = std::make_shared<STValidation>(
sit, [](PublicKey const& pk) { return calcNodeID(pk); }, false);
sit,
[](PublicKey const& pk) { return calcNodeID(pk); },
STValidation::DeserializeOptions{
.checkSignature = false, .requireCanonicalOrder = false});
fail("Expected exception not thrown from validation");
}
catch (std::exception const& ex)
@@ -249,7 +270,10 @@ public:
SerialIter sit{kPayload7};
auto val = std::make_shared<STValidation>(
sit, [](PublicKey const& pk) { return calcNodeID(pk); }, false);
sit,
[](PublicKey const& pk) { return calcNodeID(pk); },
STValidation::DeserializeOptions{
.checkSignature = false, .requireCanonicalOrder = false});
fail("Expected exception not thrown from validation");
}
@@ -279,7 +303,10 @@ public:
SerialIter sit{makeSlice(v2)};
auto val = std::make_shared<STValidation>(
sit, [](PublicKey const& pk) { return calcNodeID(pk); }, true);
sit,
[](PublicKey const& pk) { return calcNodeID(pk); },
STValidation::DeserializeOptions{
.checkSignature = true, .requireCanonicalOrder = false});
fail("Mutated validation signature checked out: offset=" + std::to_string(i));
}