ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-06-03 08:46:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Make assorted RPC fixes (#6529)

Browse Source 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This commit is contained in:
Mayukha Vadari
2026-04-29 14:05:34 -04:00
committed by GitHub
parent f7275b7ad9
commit 7be98d95de
17 changed files with 328 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

98
src/test/rpc/Submit_test.cpp Normal file
View File

@@ -0,0 +1,98 @@
#include <test/jtx/Account.h>
#include <test/jtx/Env.h>
#include <test/jtx/JTx.h>
#include <test/jtx/amount.h>
#include <test/jtx/pay.h>
#include <xrpl/basics/strHex.h>
#include <xrpl/beast/unit_test/suite.h>
#include <xrpl/json/json_value.h>
#include <xrpl/json/to_string.h>
#include <xrpl/protocol/Seed.h>
#include <xrpl/protocol/jss.h>
namespace xrpl::test {
class Submit_test : public beast::unit_test::suite
{
public:
void
testFailHardValidation()
{
testcase("fail_hard parameter validation");
using namespace jtx;
Env env(*this);
Account const alice{"alice"};
Account const bob{"bob"};
env.fund(XRP(10000), alice, bob);
env.close();
// Lambda to test invalid fail_hard parameter types
auto testInvalidFailHard = [&](auto const& param) {
// Test with tx_blob path
{
JTx const jt = env.jt(pay(alice, bob, XRP(1)));
auto const txBlob = strHex(jt.stx->getSerializer().slice());
Json::Value params;
params[jss::tx_blob] = txBlob;
params[jss::fail_hard] = param;
auto const jrr = env.rpc("json", "submit", to_string(params))[jss::result];
BEAST_EXPECT(jrr[jss::error] == "invalidParams");
BEAST_EXPECT(jrr[jss::error_message] == "Invalid field 'fail_hard', not boolean.");
}
// Test with tx_json path (deprecated signing)
{
Json::Value params;
params[jss::secret] = toBase58(generateSeed("alice"));
params[jss::tx_json] = pay("alice", "bob", XRP(1));
params[jss::fail_hard] = param;
auto const jrr = env.rpc("json", "submit", to_string(params))[jss::result];
BEAST_EXPECT(jrr[jss::error] == "invalidParams");
BEAST_EXPECT(jrr[jss::error_message] == "Invalid field 'fail_hard', not boolean.");
}
};
// Test all invalid types
testInvalidFailHard("true");
testInvalidFailHard("yes");
testInvalidFailHard(1);
testInvalidFailHard(0);
testInvalidFailHard(1.5);
testInvalidFailHard(Json::Value(Json::objectValue));
testInvalidFailHard(Json::Value(Json::arrayValue));
// Valid boolean values should work (not return invalidParams)
{
JTx const jt = env.jt(pay(alice, bob, XRP(1)));
auto const txBlob = strHex(jt.stx->getSerializer().slice());
Json::Value params;
params[jss::tx_blob] = txBlob;
params[jss::fail_hard] = true;
auto const jrr = env.rpc("json", "submit", to_string(params))[jss::result];
BEAST_EXPECT(!jrr.isMember(jss::error) || jrr[jss::error] != "invalidParams");
}
{
JTx const jt = env.jt(pay(alice, bob, XRP(1)));
auto const txBlob = strHex(jt.stx->getSerializer().slice());
Json::Value params;
params[jss::tx_blob] = txBlob;
params[jss::fail_hard] = false;
auto const jrr = env.rpc("json", "submit", to_string(params))[jss::result];
BEAST_EXPECT(!jrr.isMember(jss::error) || jrr[jss::error] != "invalidParams");
}
}
void
run() override
{
testFailHardValidation();
}
};
BEAST_DEFINE_TESTSUITE(Submit, rpc, xrpl);
} // namespace xrpl::test