From 7b69592fe164604a9ad9845ea279787c73c2fc05 Mon Sep 17 00:00:00 2001
From: Miguel Portilla <miguelportilla@pobros.com>
Date: Thu, 13 Aug 2015 10:08:00 -0400
Subject: [PATCH] Pass by reference in succ

---
 src/ripple/app/ledger/Ledger.cpp         | 2 +-
 src/ripple/app/ledger/Ledger.h           | 2 +-
 src/ripple/ledger/CachedView.h           | 2 +-
 src/ripple/ledger/OpenView.h             | 2 +-
 src/ripple/ledger/ReadView.h             | 2 +-
 src/ripple/ledger/detail/ApplyViewBase.h | 2 +-
 src/ripple/ledger/impl/ApplyViewBase.cpp | 2 +-
 src/ripple/ledger/impl/OpenView.cpp      | 2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/ripple/app/ledger/Ledger.cpp b/src/ripple/app/ledger/Ledger.cpp
index 1545f1068e..4079892a79 100644
--- a/src/ripple/app/ledger/Ledger.cpp
+++ b/src/ripple/app/ledger/Ledger.cpp
@@ -892,7 +892,7 @@ Ledger::exists (Keylet const& k) const
 
 boost::optional<uint256>
 Ledger::succ (uint256 const& key,
-    boost::optional<uint256> last) const
+    boost::optional<uint256> const& last) const
 {
     auto item = stateMap_->upper_bound(key);
     if (item == stateMap_->end())
diff --git a/src/ripple/app/ledger/Ledger.h b/src/ripple/app/ledger/Ledger.h
index b49cc4ccab..bac10579e7 100644
--- a/src/ripple/app/ledger/Ledger.h
+++ b/src/ripple/app/ledger/Ledger.h
@@ -153,7 +153,7 @@ public:
 
     boost::optional<uint256>
     succ (uint256 const& key, boost::optional<
-        uint256> last = boost::none) const override;
+        uint256> const& last = boost::none) const override;
 
     std::shared_ptr<SLE const>
     read (Keylet const& k) const override;
diff --git a/src/ripple/ledger/CachedView.h b/src/ripple/ledger/CachedView.h
index 76e519450d..a5baad3dd3 100644
--- a/src/ripple/ledger/CachedView.h
+++ b/src/ripple/ledger/CachedView.h
@@ -85,7 +85,7 @@ public:
 
     boost::optional<key_type>
     succ (key_type const& key, boost::optional<
-        key_type> last = boost::none) const override
+        key_type> const& last = boost::none) const override
     {
         return base_.succ(key, last);
     }
diff --git a/src/ripple/ledger/OpenView.h b/src/ripple/ledger/OpenView.h
index e1a0b5cd1e..423e7ff7f5 100644
--- a/src/ripple/ledger/OpenView.h
+++ b/src/ripple/ledger/OpenView.h
@@ -170,7 +170,7 @@ public:
 
     boost::optional<key_type>
     succ (key_type const& key, boost::optional<
-        key_type> last = boost::none) const override;
+        key_type> const& last = boost::none) const override;
 
     std::shared_ptr<SLE const>
     read (Keylet const& k) const override;
diff --git a/src/ripple/ledger/ReadView.h b/src/ripple/ledger/ReadView.h
index 6e7b1dafc4..ff274a2569 100644
--- a/src/ripple/ledger/ReadView.h
+++ b/src/ripple/ledger/ReadView.h
@@ -289,7 +289,7 @@ public:
     virtual
     boost::optional<key_type>
     succ (key_type const& key, boost::optional<
-        key_type> last = boost::none) const = 0;
+        key_type> const& last = boost::none) const = 0;
 
     /** Return the state item associated with a key.
 
diff --git a/src/ripple/ledger/detail/ApplyViewBase.h b/src/ripple/ledger/detail/ApplyViewBase.h
index 7d76c85ea9..afd565d1e8 100644
--- a/src/ripple/ledger/detail/ApplyViewBase.h
+++ b/src/ripple/ledger/detail/ApplyViewBase.h
@@ -71,7 +71,7 @@ public:
 
     boost::optional<key_type>
     succ (key_type const& key, boost::optional<
-        key_type> last = boost::none) const override;
+        key_type> const& last = boost::none) const override;
 
     std::shared_ptr<SLE const>
     read (Keylet const& k) const override;
diff --git a/src/ripple/ledger/impl/ApplyViewBase.cpp b/src/ripple/ledger/impl/ApplyViewBase.cpp
index 143bd1add1..22491d4ca4 100644
--- a/src/ripple/ledger/impl/ApplyViewBase.cpp
+++ b/src/ripple/ledger/impl/ApplyViewBase.cpp
@@ -59,7 +59,7 @@ ApplyViewBase::exists (Keylet const& k) const
 
 auto
 ApplyViewBase::succ (key_type const& key,
-    boost::optional<key_type> last) const ->
+    boost::optional<key_type> const& last) const ->
         boost::optional<key_type>
 {
     return items_.succ(*base_, key, last);
diff --git a/src/ripple/ledger/impl/OpenView.cpp b/src/ripple/ledger/impl/OpenView.cpp
index 7e74d14757..01a31396b4 100644
--- a/src/ripple/ledger/impl/OpenView.cpp
+++ b/src/ripple/ledger/impl/OpenView.cpp
@@ -152,7 +152,7 @@ OpenView::exists (Keylet const& k) const
 
 auto
 OpenView::succ (key_type const& key,
-    boost::optional<key_type> last) const ->
+    boost::optional<key_type> const& last) const ->
         boost::optional<key_type>
 {
     return items_.succ(*base_, key, last);