ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-11-21 11:35:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor Validations (RIPD-1412,RIPD-1356):

Browse Source 
Introduces a generic Validations class for storing and querying current and
recent validations.  Aditionally migrates the validation related timing
constants from LedgerTiming to the new Validations code.

Introduces RCLValidations as the version of Validations adapted for use in the
RCL.  This adds support for flushing/writing validations to the sqlite log and
also manages concurrent access to the Validations data.

RCLValidations::flush() no longer uses the JobQueue for its database
write at shutdown.  It performs the write directly without
changing threads.
This commit is contained in:
Brad Chase
2017-04-05 13:27:01 -04:00
committed by seelabs
parent 95f107d487
commit 7ae3c91015
25 changed files with 2312 additions and 746 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/ripple/app/misc/impl/AmendmentTable.cpp
View File

@@ -20,7 +20,7 @@
#include <BeastConfig.h>
#include <ripple/app/main/Application.h>
#include <ripple/app/misc/AmendmentTable.h>
#include <ripple/app/misc/Validations.h>
#include <ripple/protocol/STValidation.h>
#include <ripple/core/DatabaseCon.h>
#include <ripple/core/ConfigSections.h>
#include <ripple/protocol/JsonFields.h>
@@ -207,7 +207,7 @@ public:
NetClock::time_point closeTime,
std::set<uint256> const& enabledAmendments,
majorityAmendments_t const& majorityAmendments,
ValidationSet const& validations) override;
std::vector<STValidation::pointer> const& validations) override;
};
//------------------------------------------------------------------------------
@@ -411,7 +411,7 @@ AmendmentTableImpl::doVoting (
NetClock::time_point closeTime,
std::set<uint256> const& enabledAmendments,
majorityAmendments_t const& majorityAmendments,
ValidationSet const& valSet)
std::vector<STValidation::pointer> const& valSet)
{
JLOG (j_.trace()) <<
"voting at " << closeTime.time_since_epoch().count() <<
@@ -422,16 +422,16 @@ AmendmentTableImpl::doVoting (
auto vote = std::make_unique <AmendmentSet> ();
// process validations for ledger before flag ledger
for (auto const& entry : valSet)
for (auto const& val : valSet)
{
if (entry.second->isTrusted ())
if (val->isTrusted ())
{
std::set<uint256> ballot;
if (entry.second->isFieldPresent (sfAmendments))
if (val->isFieldPresent (sfAmendments))
{
auto const choices =
entry.second->getFieldV256 (sfAmendments);
val->getFieldV256 (sfAmendments);
ballot.insert (choices.begin (), choices.end ());
}