From 4c869ee16c33286fd501448d1a4ce673712778a8 Mon Sep 17 00:00:00 2001 From: Ayaz Salikhov Date: Mon, 20 Jul 2026 18:40:38 +0100 Subject: [PATCH 1/2] ci: Build separate pre-commit docker image (#7831) --- .github/workflows/build-nix-images.yml | 4 +-- .github/workflows/build-packaging-images.yml | 4 +-- .github/workflows/build-pre-commit-image.yml | 36 +++++++++++++++++++ bin/pre-commit/Dockerfile | 38 ++++++++++++++++++++ 4 files changed, 78 insertions(+), 4 deletions(-) create mode 100644 .github/workflows/build-pre-commit-image.yml create mode 100644 bin/pre-commit/Dockerfile diff --git a/.github/workflows/build-nix-images.yml b/.github/workflows/build-nix-images.yml index 54911ef6e0..da28b8db49 100644 --- a/.github/workflows/build-nix-images.yml +++ b/.github/workflows/build-nix-images.yml @@ -1,4 +1,4 @@ -name: Build Nix Docker images +name: Build `nix` Docker images on: push: @@ -36,7 +36,7 @@ defaults: jobs: build-merge: - name: Build and push nix-${{ matrix.distro.name }} + name: Build and push `nix-${{ matrix.distro.name }}` image permissions: contents: read packages: write diff --git a/.github/workflows/build-packaging-images.yml b/.github/workflows/build-packaging-images.yml index 3633847ef3..e72ea876a7 100644 --- a/.github/workflows/build-packaging-images.yml +++ b/.github/workflows/build-packaging-images.yml @@ -1,4 +1,4 @@ -name: Build packaging Docker images +name: Build `packaging` Docker images on: push: @@ -26,7 +26,7 @@ defaults: jobs: build-merge: - name: Build and push packaging-${{ matrix.distro.name }} + name: Build and push `packaging-${{ matrix.distro.name }}` image permissions: contents: read packages: write diff --git a/.github/workflows/build-pre-commit-image.yml b/.github/workflows/build-pre-commit-image.yml new file mode 100644 index 0000000000..1d0a479846 --- /dev/null +++ b/.github/workflows/build-pre-commit-image.yml @@ -0,0 +1,36 @@ +name: Build `pre-commit` Docker image + +on: + push: + branches: + - develop + paths: + - ".github/workflows/build-pre-commit-image.yml" + - "bin/pre-commit/Dockerfile" + pull_request: + paths: + - ".github/workflows/build-pre-commit-image.yml" + - "bin/pre-commit/Dockerfile" + workflow_dispatch: + +concurrency: + # Read `on-trigger.yml` for the rationale behind this concurrency group name. + group: ${{ github.workflow }}-${{ github.event_name == 'push' && github.ref == 'refs/heads/develop' && github.sha || github.ref }} + cancel-in-progress: true + +defaults: + run: + shell: bash + +jobs: + build-merge: + name: Build and push `pre-commit` image + permissions: + contents: read + packages: write + uses: XRPLF/actions/.github/workflows/build-multiarch-image.yml@ee03d31bcc4501d7599dc1b1ecd7a34af582ad1c + with: + image_name: xrpld/pre-commit + dockerfile: bin/pre-commit/Dockerfile + base_image: ubuntu:26.04 + push: ${{ github.event_name == 'push' }} diff --git a/bin/pre-commit/Dockerfile b/bin/pre-commit/Dockerfile new file mode 100644 index 0000000000..fcd07146c3 --- /dev/null +++ b/bin/pre-commit/Dockerfile @@ -0,0 +1,38 @@ +ARG BASE_IMAGE=ubuntu:26.04 + +FROM ${BASE_IMAGE} + +SHELL ["/bin/bash", "-e", "-o", "pipefail", "-c"] +ENTRYPOINT ["/bin/bash"] + +ARG DEBIAN_FRONTEND=noninteractive + +RUN < Date: Mon, 20 Jul 2026 20:11:09 +0100 Subject: [PATCH 2/2] ci: Use in-house image for pre-commit (#7610) --- .github/workflows/pre-commit.yml | 2 +- .pre-commit-config.yaml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/pre-commit.yml index 1acd28208e..37207c41ef 100644 --- a/.github/workflows/pre-commit.yml +++ b/.github/workflows/pre-commit.yml @@ -17,4 +17,4 @@ jobs: uses: XRPLF/actions/.github/workflows/pre-commit.yml@1bde119a1ab71305ba5d3716e7a82cea1c7bdede with: runs_on: ubuntu-latest - container: '{ "image": "ghcr.io/xrplf/ci/tools-rippled-pre-commit:sha-41ec7c1" }' + container: '{ "image": "ghcr.io/xrplf/xrpld/pre-commit:sha-4c869ee" }' diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 8a689c0f8b..d339cb29ed 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -55,7 +55,7 @@ repos: types_or: [c++, c] - repo: https://github.com/pre-commit/mirrors-clang-format - rev: dd18dad857d6133e90bbe478f4f2f22ec0030269 # frozen: v22.1.5 + rev: f4d7745e17a28aad7eed2f4874ca8d1568c11c4c # frozen: v22.1.8 hooks: - id: clang-format args: [--style=file] @@ -68,7 +68,7 @@ repos: - id: gersemi - repo: https://github.com/rbubley/mirrors-prettier - rev: 39e2973981e6d2f9b6c543b0086a2d2393abdc89 # frozen: v3.9.4 + rev: 9337a74165b178ae2c766f60bee7252a0f06f3e8 # frozen: v3.9.5 hooks: - id: prettier args: [--end-of-line=auto]