ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-07-25 16:10:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Review feedback: STNumber parsing

Browse Source 
- In numberFromJson(), if the result is 0, only the mantissa has to
  match, because there are many valid ways to represent 0.
- Update several broken tests that I missed earlier.
This commit is contained in:
Ed Hennis
2026-06-26 14:08:53 -04:00
parent 573bf2abe3
commit 78c5471af6
2 changed files with 61 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
src/test/protocol/STNumber_test.cpp
View File

@@ -108,23 +108,43 @@ struct STNumber_test : public beast::unit_test::Suite
auto const minInt = std::to_string(std::numeric_limits<std::int64_t>::min());
if (Number::getMantissaScale() == MantissaRange::MantissaScale::Small)
{
BEAST_EXPECT(
numberFromJson(sfNumber, maxInt) ==
STNumber(sfNumber, Number{9'223'372'036'854'775, 3}));
BEAST_EXPECT(
numberFromJson(sfNumber, minInt) ==
STNumber(sfNumber, Number{-9'223'372'036'854'775, 3}));
// min/maxInt can't be exactly represented with the small mantissa, so they
// don't parse, and are expected to throw.
try
{
auto const bad = numberFromJson(sfNumber, maxInt);
fail();
}
catch (std::exception const& e)
{
BEAST_EXPECT(std::string(e.what()) == "number can not be represented");
}
try
{
auto const bad = numberFromJson(sfNumber, minInt);
fail();
}
catch (std::exception const& e)
{
BEAST_EXPECT(std::string(e.what()) == "number can not be represented");
}
}
else
{
// with large mantissas, maxint is fine
BEAST_EXPECT(
numberFromJson(sfNumber, maxInt) ==
STNumber(sfNumber, Number{9'223'372'036'854'775'807, 0}));
BEAST_EXPECT(
numberFromJson(sfNumber, minInt) ==
STNumber(
sfNumber,
Number{true, 9'223'372'036'854'775'808ULL, 0, Number::Normalized{}}));
// but minint's mantissa is > kMaxRep, and so rounds, and thus can't be parsed
try
{
auto const bad = numberFromJson(sfNumber, minInt);
fail();
}
catch (std::exception const& e)
{
BEAST_EXPECT(std::string(e.what()) == "number can not be represented");
}
}
}