ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make XRPAmount constructor explicit:

Browse Source 
Remove the implicit conversion from int64 to XRPAmount. The motivation for this
was noticing that many calls to `to_string` with an integer parameter type were
calling the wrong `to_string` function. Since the calls were not prefixed with
`std::`, and there is no ADL to call `std::to_string`, this was converting the
int to an `XRPAmount` and calling `to_string(XRPAmount)`.

Since `to_string(XRPAmount)` did the same thing as `to_string(int)` this error
went undetected.
This commit is contained in:
seelabs
2019-08-28 11:44:36 -07:00
parent e3b5b808c5
commit 761bb5744e
23 changed files with 87 additions and 77 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/test/server/ServerStatus_test.cpp
View File

@@ -593,7 +593,7 @@ class ServerStatus_test :
using namespace boost::asio;
using namespace boost::beast::http;
Env env {*this, envconfig([&](std::unique_ptr<Config> cfg) {
(*cfg)["port_rpc"].set("limit", to_string(limit));
(*cfg)["port_rpc"].set("limit", std::to_string(limit));
return cfg;
})};
@@ -612,7 +612,7 @@ class ServerStatus_test :
auto it =
r.async_resolve(
ip::tcp::resolver::query{ip, to_string(port)}, yield[ec]);
ip::tcp::resolver::query{ip, std::to_string(port)}, yield[ec]);
BEAST_EXPECT(! ec);
std::vector<std::pair<ip::tcp::socket, boost::beast::multi_buffer>> clients;
@@ -721,7 +721,7 @@ class ServerStatus_test :
auto it =
r.async_resolve(
ip::tcp::resolver::query{ip, to_string(port)}, yield[ec]);
ip::tcp::resolver::query{ip, std::to_string(port)}, yield[ec]);
if(! BEAST_EXPECT(! ec))
return;
@@ -731,7 +731,7 @@ class ServerStatus_test :
return;
boost::beast::websocket::stream<boost::asio::ip::tcp::socket&> ws{sock};
ws.handshake(ip + ":" + to_string(port), "/");
ws.handshake(ip + ":" + std::to_string(port), "/");
// helper lambda, used below
auto sendAndParse = [&](std::string const& req) -> Json::Value