refactor: Enable remaining clang-tidy cppcoreguidelines checks (#6538)

This commit is contained in:
Alex Kremer
2026-03-17 19:09:05 +00:00
committed by GitHub
parent b523770486
commit 72f4cb097f
148 changed files with 424 additions and 397 deletions

View File

@@ -46,7 +46,7 @@ STObject::STObject(STObject&& other)
{
}
STObject::STObject(SField const& name) : STBase(name), mType(nullptr)
STObject::STObject(SField const& name) : STBase(name)
{
}
@@ -62,8 +62,7 @@ STObject::STObject(SOTemplate const& type, SerialIter& sit, SField const& name)
applyTemplate(type); // May throw
}
STObject::STObject(SerialIter& sit, SField const& name, int depth) noexcept(false)
: STBase(name), mType(nullptr)
STObject::STObject(SerialIter& sit, SField const& name, int depth) noexcept(false) : STBase(name)
{
if (depth > 10)
Throw<std::runtime_error>("Maximum nesting depth of STObject exceeded");
@@ -216,8 +215,8 @@ STObject::set(SerialIter& sit, int depth)
// Consume data in the pipe until we run out or reach the end
while (!sit.empty())
{
int type;
int field;
int type = 0;
int field = 0;
// Get the metadata for the next field
sit.getFieldID(type, field);