ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-11-30 07:55:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Always enable fix1298 dated December 21, 2016 18:00:00 UTC

Browse Source
This commit is contained in:
Scott Schurr
2019-12-13 14:27:46 -08:00
committed by Manoj doshi
parent 0964379a66
commit 70c21f90b9
6 changed files with 13 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/ripple/app/paths/impl/BookStep.cpp
View File

@@ -714,14 +714,12 @@ BookStep<TIn, TOut, TDerived>::revImp (
result.out = out;
this->consumeOffer (sb, offer, ofrAdjAmt, stpAdjAmt, ownerGivesAdj);
// When the mantissas of two iou amounts differ by less than ten, then
// subtracting them leaves a result of zero. This can cause the check for
// (stpAmt.out > remainingOut) to incorrectly think an offer will be funded
// after subtracting remainingIn.
if (fix1298(sb.parentCloseTime()))
return offer.fully_consumed();
else
return false;
// Explicitly check whether the offer is funded. Given that we have
// (stpAmt.out > remainingOut), it's natural to assume the offer
// will still be funded after consuming remainingOut but that is
// not always the case. If the mantissas of two IOU amounts differ
// by less than ten, then subtracting them leaves a zero.
return offer.fully_consumed();
}
};
@@ -884,10 +882,7 @@ BookStep<TIn, TOut, TDerived>::fwdImp (
// subtracting them leaves a result of zero. This can cause the check for
// (stpAmt.in > remainingIn) to incorrectly think an offer will be funded
// after subtracting remainingIn.
if (fix1298(sb.parentCloseTime()))
processMore = processMore || offer.fully_consumed();
return processMore;
return processMore || offer.fully_consumed();
};
{