diff --git a/src/libxrpl/protocol/STTx.cpp b/src/libxrpl/protocol/STTx.cpp index 2ab5deb66d..a7b6c29ec0 100644 --- a/src/libxrpl/protocol/STTx.cpp +++ b/src/libxrpl/protocol/STTx.cpp @@ -728,7 +728,7 @@ isRawTransactionOkay(STObject const& st, std::string& reason) reason = "Raw Transactions array exceeds max entries."; return false; } - for (auto raw : rawTxns) + for (STObject raw : rawTxns) { try { diff --git a/src/libxrpl/tx/transactors/system/Batch.cpp b/src/libxrpl/tx/transactors/system/Batch.cpp index e762b9de74..2386ae59a1 100644 --- a/src/libxrpl/tx/transactors/system/Batch.cpp +++ b/src/libxrpl/tx/transactors/system/Batch.cpp @@ -63,9 +63,9 @@ Batch::calculateBaseFee(ReadView const& view, STTx const& tx) } // LCOV_EXCL_STOP - for (auto const& txn : txns) + for (STObject txn : txns) { - STTx const stx = STTx{STObject(txn)}; + STTx const stx = STTx{std::move(txn)}; // LCOV_EXCL_START if (stx.getTxnType() == ttBATCH) @@ -256,9 +256,9 @@ Batch::preflight(PreflightContext const& ctx) return tesSUCCESS; }; - for (auto const& rb : rawTxns) + for (STObject rb : rawTxns) { - STTx const stx = STTx{STObject(rb)}; + STTx const stx = STTx{std::move(rb)}; auto const hash = stx.getTransactionID(); if (!uniqueHashes.emplace(hash).second) {