ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid a mutex 99+% of the time in SField::getField

Browse Source
This commit is contained in:
JoelKatz
2014-07-30 22:31:56 -07:00
committed by Vinnie Falco
parent c9cd7e4be0
commit 6bb5be5216
2 changed files with 62 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/ripple/module/data/protocol/FieldNames.h
View File

@@ -91,9 +91,7 @@ public:
, rawJsonName (getName ())
, jsonName (rawJsonName.c_str ())
{
StaticScopedLockType sl (getMutex ());
codeToField[fieldCode] = this;
knownCodeToField[fieldCode] = this;
fieldNum = ++num;
}
@@ -108,9 +106,7 @@ public:
, rawJsonName (getName ())
, jsonName (rawJsonName.c_str ())
{
StaticScopedLockType sl (getMutex ());
codeToField[fieldCode] = this;
knownCodeToField[fieldCode] = this;
fieldNum = ++num;
}
@@ -173,7 +169,10 @@ public:
return fieldValue < 256;
}
// VFALCO NOTE What is a discardable field?
// A discardable field is one that cannot be serialized, and
// should be discarded during serialization,like 'hash'.
// You cannot serialize an object's hash inside that object,
// but you can have it in the JSON representation.
bool isDiscardable () const
{
return fieldValue > 256;
@@ -228,7 +227,12 @@ public:
// VFALCO TODO make these private
protected:
static std::map<int, ptr> codeToField;
// Fields that are known at compile time
static std::map <int, ptr> knownCodeToField;
// Field that are discovered at run time
static std::map <int, ptr> unknownCodeToField;
typedef RippleMutex StaticLockType;
typedef std::lock_guard <StaticLockType> StaticScopedLockType;