From 69656d6b675e61ab194b6d1f44c03961bb33cc77 Mon Sep 17 00:00:00 2001 From: Ed Hennis Date: Thu, 14 May 2026 18:22:39 -0400 Subject: [PATCH] clang-tidy: Avoid nested "?:" in global Rules initialization --- src/libxrpl/protocol/Rules.cpp | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/libxrpl/protocol/Rules.cpp b/src/libxrpl/protocol/Rules.cpp index b5861a8ebd..1461734465 100644 --- a/src/libxrpl/protocol/Rules.cpp +++ b/src/libxrpl/protocol/Rules.cpp @@ -56,10 +56,16 @@ setCurrentTransactionRules(std::optional r) XRPL_ASSERT( !r || useRulesGuards(*r) == (enableCuspRoundingFix || enableVaultNumbers), "setCurrentTransactionRules : rule decisions match"); - Number::setMantissaScale( - enableCuspRoundingFix ? MantissaRange::MantissaScale::Large - : (enableVaultNumbers ? MantissaRange::MantissaScale::LargeLegacy - : MantissaRange::MantissaScale::Small)); + + // Declare the range this way to keep clang-tidy from complaining + auto const range = [enableCuspRoundingFix, enableVaultNumbers]() { + if (enableCuspRoundingFix) + return MantissaRange::MantissaScale::Large; + else if (enableVaultNumbers) + return MantissaRange::MantissaScale::LargeLegacy; + return MantissaRange::MantissaScale::Small; + }(); + Number::setMantissaRange(range); *getCurrentTransactionRulesRef() = std::move(r); }