From 683ff84ee09ce99df2b834a7ddbdd42d9a7d49dc Mon Sep 17 00:00:00 2001 From: Mayukha Vadari Date: Wed, 8 Apr 2026 16:42:53 -0400 Subject: [PATCH] respond to copilot comments --- include/xrpl/ledger/helpers/AccountRootHelpers.h | 3 +-- src/libxrpl/tx/transactors/lending/LendingHelpers.cpp | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/include/xrpl/ledger/helpers/AccountRootHelpers.h b/include/xrpl/ledger/helpers/AccountRootHelpers.h index 182a14dce0..124da3d6b0 100644 --- a/include/xrpl/ledger/helpers/AccountRootHelpers.h +++ b/include/xrpl/ledger/helpers/AccountRootHelpers.h @@ -60,8 +60,7 @@ public: { } - /** Create an AccountRoot backed by a brand-new SLE - * (not yet inserted into the view). + /** Create an AccountRoot backed by a brand-new SLE. */ [[nodiscard]] static AccountRoot makeNew( diff --git a/src/libxrpl/tx/transactors/lending/LendingHelpers.cpp b/src/libxrpl/tx/transactors/lending/LendingHelpers.cpp index 9907e465a5..1ae6514fa7 100644 --- a/src/libxrpl/tx/transactors/lending/LendingHelpers.cpp +++ b/src/libxrpl/tx/transactors/lending/LendingHelpers.cpp @@ -1950,11 +1950,11 @@ adjustOwnerCount( std::int32_t amount, beast::Journal j) { + if (!sle) + return; // This function is only used for LoanBrokers, so assert that // AccountRoot should use WAccountRoot.adjustOwnerCount instead XRPL_ASSERT(sle->getType() == ltLOAN_BROKER, "xrpl::adjustOwnerCount : sle is loan broker"); - if (!sle) - return; XRPL_ASSERT(amount, "xrpl::adjustOwnerCount : nonzero amount input"); std::uint32_t const current{sle->getFieldU32(sfOwnerCount)}; AccountID const id = (*sle)[sfAccount];