From 65817c4c57a3db60bf7d8d23da8bb35cdd18c185 Mon Sep 17 00:00:00 2001
From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>
Date: Mon, 20 Apr 2026 15:22:06 +0100
Subject: [PATCH] fix(telemetry): align TelemetryConfig tests with current API

- serviceName default is "xrpld" not "rippled"
- Remove references to nonexistent exporterType field
- Pass networkId (4th param) to setup_Telemetry()

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 src/tests/libxrpl/telemetry/TelemetryConfig.cpp | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/src/tests/libxrpl/telemetry/TelemetryConfig.cpp b/src/tests/libxrpl/telemetry/TelemetryConfig.cpp
index de58a3827f..bbd2fea8a5 100644
--- a/src/tests/libxrpl/telemetry/TelemetryConfig.cpp
+++ b/src/tests/libxrpl/telemetry/TelemetryConfig.cpp
@@ -11,10 +11,9 @@ TEST(TelemetryConfig, setup_defaults)
 {
     telemetry::Telemetry::Setup s;
     EXPECT_FALSE(s.enabled);
-    EXPECT_EQ(s.serviceName, "rippled");
+    EXPECT_EQ(s.serviceName, "xrpld");
     EXPECT_TRUE(s.serviceVersion.empty());
     EXPECT_TRUE(s.serviceInstanceId.empty());
-    EXPECT_EQ(s.exporterType, "otlp_http");
     EXPECT_EQ(s.exporterEndpoint, "http://localhost:4318/v1/traces");
     EXPECT_FALSE(s.useTls);
     EXPECT_TRUE(s.tlsCertPath.empty());
@@ -34,13 +33,12 @@ TEST(TelemetryConfig, setup_defaults)
 TEST(TelemetryConfig, parse_empty_section)
 {
     Section section;
-    auto setup = telemetry::setup_Telemetry(section, "nHUtest123", "2.0.0");
+    auto setup = telemetry::setup_Telemetry(section, "nHUtest123", "2.0.0", 0);
 
     EXPECT_FALSE(setup.enabled);
-    EXPECT_EQ(setup.serviceName, "rippled");
+    EXPECT_EQ(setup.serviceName, "xrpld");
     EXPECT_EQ(setup.serviceVersion, "2.0.0");
     EXPECT_EQ(setup.serviceInstanceId, "nHUtest123");
-    EXPECT_EQ(setup.exporterType, "otlp_http");
     EXPECT_DOUBLE_EQ(setup.samplingRatio, 1.0);
     EXPECT_TRUE(setup.traceRpc);
     EXPECT_TRUE(setup.traceTransactions);
@@ -69,12 +67,11 @@ TEST(TelemetryConfig, parse_full_section)
     section.set("trace_peer", "1");
     section.set("trace_ledger", "0");
 
-    auto setup = telemetry::setup_Telemetry(section, "nHUtest123", "2.0.0");
+    auto setup = telemetry::setup_Telemetry(section, "nHUtest123", "2.0.0", 1);
 
     EXPECT_TRUE(setup.enabled);
     EXPECT_EQ(setup.serviceName, "my-rippled");
     EXPECT_EQ(setup.serviceInstanceId, "custom-id");
-    EXPECT_EQ(setup.exporterType, "otlp_http");
     EXPECT_EQ(setup.exporterEndpoint, "http://collector:4318/v1/traces");
     EXPECT_TRUE(setup.useTls);
     EXPECT_EQ(setup.tlsCertPath, "/etc/ssl/ca.pem");