From 0ed0c01021cc804d1abf7ec4350ff0f103a4eed5 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Tue, 8 Sep 2026 17:12:40 +0100 Subject: [PATCH 1/2] fix(docs): spell it "XRPL epoch" in the ledger attribute table The rename script rewrites "Ripple epoch" to "XRPL epoch", so the old spelling in a tracked .md makes the check-rename job fail on a dirty tree. The attribute key close_time_ripple_epoch_s is left alone: the script's pattern needs a space, and that key is a cross-layer contract. --- OpenTelemetryPlan/02-design-decisions.md | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/OpenTelemetryPlan/02-design-decisions.md b/OpenTelemetryPlan/02-design-decisions.md index dae5e8fe82..09484baaae 100644 --- a/OpenTelemetryPlan/02-design-decisions.md +++ b/OpenTelemetryPlan/02-design-decisions.md @@ -288,15 +288,15 @@ keys (the dotted form is reserved for resource scope per §2.3.3). #### Ledger & Job Attributes -| Key | Type | Description | -| --------------------------- | ------- | --------------------------------- | -| `ledger_hash` | string | Ledger hash | -| `ledger_seq` | int64 | Closed/validated ledger sequence | -| `close_time_ripple_epoch_s` | int64 | Close time (Ripple epoch seconds) | -| `ledger_tx_count` | int64 | Transaction count | -| `job_type` | string | Job type name | -| `job_queue_ms` | float64 | Time spent in queue | -| `job_worker` | int64 | Worker thread ID | +| Key | Type | Description | +| --------------------------- | ------- | -------------------------------- | +| `ledger_hash` | string | Ledger hash | +| `ledger_seq` | int64 | Closed/validated ledger sequence | +| `close_time_ripple_epoch_s` | int64 | Close time (XRPL epoch seconds) | +| `ledger_tx_count` | int64 | Transaction count | +| `job_type` | string | Job type name | +| `job_queue_ms` | float64 | Time spent in queue | +| `job_worker` | int64 | Worker thread ID | #### PathFinding Attributes From 25362d3b6aabe71fe26e3d7ac6fef3b7907cc7d0 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Tue, 8 Sep 2026 17:12:53 +0100 Subject: [PATCH 2/2] fix(docs): spell it "XRPL epoch" in the close-time attribute notes The rename script rewrites "Ripple epoch" to "XRPL epoch", so the old spelling in a tracked .md makes the check-rename job fail on a dirty tree. The attribute keys are left alone: the script's pattern needs a space, and those keys are a cross-layer contract. --- OpenTelemetryPlan/Phase4_taskList.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/OpenTelemetryPlan/Phase4_taskList.md b/OpenTelemetryPlan/Phase4_taskList.md index a20385e664..4b64255e9c 100644 --- a/OpenTelemetryPlan/Phase4_taskList.md +++ b/OpenTelemetryPlan/Phase4_taskList.md @@ -333,13 +333,13 @@ Phase 7's `ValidationTracker` builds metric-level aggregation (1h/24h agreement The `consensus.accept.apply` span captures ledger close time agreement details driven by `avCT_CONSENSUS_PCT` (75% validator agreement threshold): -- **`close_time_ripple_epoch_s`** — Agreed-upon ledger close time (Ripple epoch seconds). When validators disagree (`consensusCloseTime == epoch`), this is synthetically set to `prevCloseTime + 1s`. +- **`close_time_ripple_epoch_s`** — Agreed-upon ledger close time (XRPL epoch seconds). When validators disagree (`consensusCloseTime == epoch`), this is synthetically set to `prevCloseTime + 1s`. - **`close_time_correct`** — `true` if validators reached agreement, `false` if they "agreed to disagree" (close time forced to prev+1s). - **`close_resolution_ms`** — Rounding granularity for close time (starts at 30s, decreases as ledger interval stabilizes). - **`consensus_state`** — `"finished"` (normal) or `"moved_on"` (consensus failed, adopted best available). - **`proposing`** — Whether this node was proposing. - **`round_time_ms`** — Total consensus round duration. -- **`parent_close_time_ripple_epoch_s`** — Previous ledger's close time (Ripple epoch seconds). Enables computing close-time deltas across consecutive rounds without correlating separate spans. +- **`parent_close_time_ripple_epoch_s`** — Previous ledger's close time (XRPL epoch seconds). Enables computing close-time deltas across consecutive rounds without correlating separate spans. - **`close_time_self_ripple_epoch_s`** — This node's own proposed close time before consensus voting. - **`close_time_vote_bins`** — Number of distinct close-time vote bins from peer proposals. Higher values indicate less agreement among validators. - **`resolution_direction`** — Whether close-time resolution `"increased"` (coarser), `"decreased"` (finer), or stayed `"unchanged"` relative to the previous ledger.