diff --git a/src/ripple/app/tx/impl/CreateOffer.cpp b/src/ripple/app/tx/impl/CreateOffer.cpp index 6e58731887..85a9c4c8a2 100644 --- a/src/ripple/app/tx/impl/CreateOffer.cpp +++ b/src/ripple/app/tx/impl/CreateOffer.cpp @@ -638,7 +638,7 @@ CreateOffer::takerCross( Sandbox& sbCancel, Amounts const& takerAmount) { - NetClock::time_point const when{ctx_.view().parentCloseTime()}; + NetClock::time_point const when = ctx_.view().parentCloseTime(); beast::WrappedSink takerSink(j_, "Taker "); diff --git a/src/ripple/consensus/Validations.h b/src/ripple/consensus/Validations.h index fce13cebf3..f883f773eb 100644 --- a/src/ripple/consensus/Validations.h +++ b/src/ripple/consensus/Validations.h @@ -152,7 +152,9 @@ isCurrent( // Because this can be called on untrusted, possibly // malicious validations, we do our math in a way // that avoids any chance of overflowing or underflowing - // the signing time. + // the signing time. All of the expressions below are + // promoted from unsigned 32 bit to signed 64 bit prior + // to computation. return (signTime > (now - p.validationCURRENT_EARLY)) && (signTime < (now + p.validationCURRENT_WALL)) && diff --git a/src/ripple/overlay/impl/Handshake.cpp b/src/ripple/overlay/impl/Handshake.cpp index 266fb2acb1..b28e5ba356 100644 --- a/src/ripple/overlay/impl/Handshake.cpp +++ b/src/ripple/overlay/impl/Handshake.cpp @@ -268,7 +268,6 @@ verifyHandshake( // We can't blindly "return a-b;" because TimeKeeper::time_point // uses an unsigned integer for representing durations, which is // a problem when trying to subtract time points. - // FIXME: @HowardHinnant, should we migrate to using std::int64_t? auto calculateOffset = [](TimeKeeper::time_point a, TimeKeeper::time_point b) { if (a > b)