ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-04-29 15:37:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove default ctors from SecretKey and PublicKey: (#4607)

Browse Source 
* It is now an invariant that all constructed Public Keys are valid,
  non-empty and contain 33 bytes of data.
* Additionally, the memory footprint of the PublicKey class is reduced.
  The size_ data member is declared as static.
* Distinguish and identify the PublisherList retrieved from the local
  config file, versus the ones obtained from other validators.
* Fixes #2942
This commit is contained in:
Chenna Keshava B S
2024-03-05 09:02:53 -08:00
committed by GitHub
parent 97863e0b62
commit 62dae3c6c6
39 changed files with 545 additions and 349 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/test/app/ValidatorKeys_test.cpp
View File

@@ -107,7 +107,7 @@ public:
// No config -> no key but valid
Config c;
ValidatorKeys k{c, journal};
BEAST_EXPECT(k.publicKey.size() == 0);
BEAST_EXPECT(!k.keys);
BEAST_EXPECT(k.manifest.empty());
BEAST_EXPECT(!k.configInvalid());
}
@@ -117,8 +117,11 @@ public:
c.section(SECTION_VALIDATION_SEED).append(seed);
ValidatorKeys k{c, journal};
BEAST_EXPECT(k.publicKey == seedPublicKey);
BEAST_EXPECT(k.secretKey == seedSecretKey);
if (BEAST_EXPECT(k.keys))
{
BEAST_EXPECT(k.keys->publicKey == seedPublicKey);
BEAST_EXPECT(k.keys->secretKey == seedSecretKey);
}
BEAST_EXPECT(k.nodeID == seedNodeID);
BEAST_EXPECT(k.manifest.empty());
BEAST_EXPECT(!k.configInvalid());
@@ -131,7 +134,7 @@ public:
ValidatorKeys k{c, journal};
BEAST_EXPECT(k.configInvalid());
BEAST_EXPECT(k.publicKey.size() == 0);
BEAST_EXPECT(!k.keys);
BEAST_EXPECT(k.manifest.empty());
}
@@ -141,8 +144,11 @@ public:
c.section(SECTION_VALIDATOR_TOKEN).append(tokenBlob);
ValidatorKeys k{c, journal};
BEAST_EXPECT(k.publicKey == tokenPublicKey);
BEAST_EXPECT(k.secretKey == tokenSecretKey);
if (BEAST_EXPECT(k.keys))
{
BEAST_EXPECT(k.keys->publicKey == tokenPublicKey);
BEAST_EXPECT(k.keys->secretKey == tokenSecretKey);
}
BEAST_EXPECT(k.nodeID == tokenNodeID);
BEAST_EXPECT(k.manifest == tokenManifest);
BEAST_EXPECT(!k.configInvalid());
@@ -153,7 +159,7 @@ public:
c.section(SECTION_VALIDATOR_TOKEN).append("badtoken");
ValidatorKeys k{c, journal};
BEAST_EXPECT(k.configInvalid());
BEAST_EXPECT(k.publicKey.size() == 0);
BEAST_EXPECT(!k.keys);
BEAST_EXPECT(k.manifest.empty());
}
@@ -165,7 +171,7 @@ public:
ValidatorKeys k{c, journal};
BEAST_EXPECT(k.configInvalid());
BEAST_EXPECT(k.publicKey.size() == 0);
BEAST_EXPECT(!k.keys);
BEAST_EXPECT(k.manifest.empty());
}
@@ -176,7 +182,7 @@ public:
ValidatorKeys k{c, journal};
BEAST_EXPECT(k.configInvalid());
BEAST_EXPECT(k.publicKey.size() == 0);
BEAST_EXPECT(!k.keys);
BEAST_EXPECT(k.manifest.empty());
}
}