ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove validation cookie support code

Browse Source
This commit is contained in:
Brad Chase
2018-05-04 11:59:33 -04:00
committed by Nikolaos D. Bougalis
parent 04f1388860
commit 6156ff3eb7
16 changed files with 9 additions and 171 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/ripple/protocol/Feature.h
View File

@@ -78,7 +78,6 @@ class FeatureCollections
"Checks",
"fix1571",
"fix1543",
"ValidationCookies",
"fix1623"
};
@@ -363,7 +362,6 @@ extern uint256 const featureDepositAuth;
extern uint256 const featureChecks;
extern uint256 const fix1571;
extern uint256 const fix1543;
extern uint256 const featureValidationCookies;
extern uint256 const fix1623;
} // ripple

4
src/ripple/protocol/STValidation.h
View File

@@ -117,7 +117,6 @@ public:
@param isFull Whether the validation is full or partial
@param fee FeeSettings to include in the validation
@param amendments If not empty, the amendments to include in this validation
@param cookie If not none, the validation cookie to set
@note The fee and amendment settings are only set if not boost::none.
Typically, the amendments and fees are set for validations of flag
@@ -133,8 +132,7 @@ public:
NodeID const& nodeID,
bool isFull,
FeeSettings const& fees,
std::vector<uint256> const& amendments,
boost::optional<std::uint64_t> const cookie);
std::vector<uint256> const& amendments);
STBase*
copy(std::size_t n, void* buf) const override

2
src/ripple/protocol/impl/Feature.cpp
View File

@@ -110,7 +110,6 @@ detail::supportedAmendments ()
{ "157D2D480E006395B76F948E3E07A45A05FE10230D88A7993C71F97AE4B1F2D1 Checks" },
{ "7117E2EC2DBF119CA55181D69819F1999ECEE1A0225A7FD2B9ED47940968479C fix1571" },
{ "CA7C02118BA27599528543DFE77BA6838D1B0F43B447D4D7F53523CE6A0E9AC2 fix1543" },
{ "8413364A1E27704241F7106789570A4B36EE2AFA14F94828E78BE942AB2F24BE ValidationCookies" },
{ "58BE9B5968C4DA7C59BA900961828B113E5490699B21877DEF9A31E9D0FE5D5F fix1623" }
};
return supported;
@@ -163,7 +162,6 @@ uint256 const featureDepositAuth = *getRegisteredFeature("DepositAuth");
uint256 const featureChecks = *getRegisteredFeature("Checks");
uint256 const fix1571 = *getRegisteredFeature("fix1571");
uint256 const fix1543 = *getRegisteredFeature("fix1543");
uint256 const featureValidationCookies = *getRegisteredFeature("ValidationCookies");
uint256 const fix1623 = *getRegisteredFeature("fix1623");
} // ripple

5
src/ripple/protocol/impl/STValidation.cpp
View File

@@ -35,8 +35,7 @@ STValidation::STValidation(
NodeID const& nodeID,
bool isFull,
FeeSettings const& fees,
std::vector<uint256> const& amendments,
boost::optional<std::uint64_t> const cookie)
std::vector<uint256> const& amendments)
: STObject(getFormat(), sfValidation), mNodeID(nodeID), mSeen(signTime)
{
// This is our own public key and it should always be valid.
@@ -70,8 +69,6 @@ STValidation::STValidation(
setFlag(vfFullyCanonicalSig);
if(cookie != boost::none)
setFieldU64(sfCookie, *cookie);
auto const signingHash = getSigningHash();
setFieldVL(
sfSignature, signDigest(getSignerPublic(), secretKey, signingHash));