From b1af0a9511e45562e3a26b9d440eac219e8bd92e Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Tue, 7 Jul 2026 19:43:40 +0100 Subject: [PATCH 1/2] docs(telemetry): remove Phase reference from tempo.yaml base-filter comment Reviewer noted implementation-phase references should not appear in shipped config comments. Drop the "Phase 1b" token, keep the filter description. Co-Authored-By: Claude Opus 4.8 --- docker/telemetry/grafana/provisioning/datasources/tempo.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docker/telemetry/grafana/provisioning/datasources/tempo.yaml b/docker/telemetry/grafana/provisioning/datasources/tempo.yaml index 4214c72494..46ea429167 100644 --- a/docker/telemetry/grafana/provisioning/datasources/tempo.yaml +++ b/docker/telemetry/grafana/provisioning/datasources/tempo.yaml @@ -5,7 +5,7 @@ # # Search filters provide pre-configured dropdowns in the Explore UI. # Each phase adds filters for the span attributes it introduces. -# Phase 1b (infra): Base filters — node identity, service, span name, status. +# Base filters — node identity, service, span name, status. apiVersion: 1 From 9879780dd8675798b5c85a2fb8f744100915ebe8 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Tue, 7 Jul 2026 19:43:53 +0100 Subject: [PATCH 2/2] docs(telemetry): remove Phase references from tempo.yaml RPC filter comments Reviewer noted implementation-phase references should not appear in shipped config comments. Drop the "Phase 2" tokens, keep descriptions. Co-Authored-By: Claude Opus 4.8 --- docker/telemetry/grafana/provisioning/datasources/tempo.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docker/telemetry/grafana/provisioning/datasources/tempo.yaml b/docker/telemetry/grafana/provisioning/datasources/tempo.yaml index b77f3e9b31..f1eddb1eca 100644 --- a/docker/telemetry/grafana/provisioning/datasources/tempo.yaml +++ b/docker/telemetry/grafana/provisioning/datasources/tempo.yaml @@ -6,7 +6,7 @@ # Search filters provide pre-configured dropdowns in the Explore UI. # Each phase adds filters for the span attributes it introduces. # Phase 1b (infra): Base filters — node identity, service, span name, status. -# Phase 2 (RPC): RPC command, status, role filters. +# RPC command, status, role filters. apiVersion: 1 @@ -90,7 +90,7 @@ datasources: operator: ">" scope: intrinsic type: dynamic - # Phase 2: RPC tracing filters + # RPC tracing filters - id: rpc-command tag: command operator: "="