From c157253372b26e153c9e883caf9c97a9b2611ff2 Mon Sep 17 00:00:00 2001
From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>
Date: Fri, 29 May 2026 18:51:47 +0100
Subject: [PATCH] activate telemetry by default and fix clang-tidy issues.

Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>
---
 CMakeLists.txt                          | 2 +-
 conanfile.py                            | 2 +-
 src/libxrpl/telemetry/NullTelemetry.cpp | 6 +++++-
 3 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index ffa9ce3947..5a0ac32b92 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -122,7 +122,7 @@ endif()
 # so that tracing macros in TracingInstrumentation.h are compiled in.
 # When OFF (default), all tracing code compiles to no-ops with zero overhead.
 # Enable via: conan install -o telemetry=True, or cmake -Dtelemetry=ON.
-option(telemetry "Enable OpenTelemetry tracing" OFF)
+option(telemetry "Enable OpenTelemetry tracing" ON)
 if(telemetry)
     find_package(opentelemetry-cpp CONFIG REQUIRED)
     add_compile_definitions(XRPL_ENABLE_TELEMETRY)
diff --git a/conanfile.py b/conanfile.py
index 36b50e4b4e..951ce41135 100644
--- a/conanfile.py
+++ b/conanfile.py
@@ -54,7 +54,7 @@ class Xrpl(ConanFile):
         "rocksdb": True,
         "shared": False,
         "static": True,
-        "telemetry": False,
+        "telemetry": True,
         "tests": False,
         "unity": False,
         "xrpld": False,
diff --git a/src/libxrpl/telemetry/NullTelemetry.cpp b/src/libxrpl/telemetry/NullTelemetry.cpp
index 7cbfd24019..812220acdb 100644
--- a/src/libxrpl/telemetry/NullTelemetry.cpp
+++ b/src/libxrpl/telemetry/NullTelemetry.cpp
@@ -10,12 +10,16 @@
     its own factory that can return the real TelemetryImpl.
 */
 
+#include <xrpl/beast/utility/Journal.h>
 #include <xrpl/telemetry/Telemetry.h>
 
-#include <string_view>
+#include <memory>
+#include <utility>
 
 #ifdef XRPL_ENABLE_TELEMETRY
 #include <opentelemetry/trace/noop.h>
+
+#include <string_view>
 #endif
 
 namespace xrpl::telemetry {