From 5c95d1112705a85c00ad38ac775b837ae26fa421 Mon Sep 17 00:00:00 2001 From: Mayukha Vadari Date: Thu, 23 Jul 2026 15:41:57 -0400 Subject: [PATCH] respond to comments --- bin/pre-commit/clang_tidy_check.py | 2 +- src/test/app/Offer_test.cpp | 11 +++-------- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/bin/pre-commit/clang_tidy_check.py b/bin/pre-commit/clang_tidy_check.py index cf4808d2ea..fd68c33adf 100755 --- a/bin/pre-commit/clang_tidy_check.py +++ b/bin/pre-commit/clang_tidy_check.py @@ -49,6 +49,7 @@ def find_tool(name: str) -> str | None: def find_build_dir(repo_root: Path) -> Path | None: for name in (".build", "build"): candidate = repo_root / name + print("find_build_dir: candidate: ", candidate) if (candidate / "compile_commands.json").exists(): return candidate return None @@ -94,7 +95,6 @@ def main(): repo_root = Path( subprocess.check_output( ["git", "rev-parse", "--show-toplevel"], - cwd=Path(__file__).parent, text=True, ).strip() ) diff --git a/src/test/app/Offer_test.cpp b/src/test/app/Offer_test.cpp index f335073eb1..33721e91d8 100644 --- a/src/test/app/Offer_test.cpp +++ b/src/test/app/Offer_test.cpp @@ -4351,6 +4351,9 @@ public: auto const gw = Account("gw"); auto const alice = Account("alice"); auto const bob = Account("bob"); + auto const carol = Account("carol"); + auto const dan = Account("dan"); + auto const eve = Account("eve"); auto const gwUSD = gw["USD"]; // Test without fixCleanup3_4_0 amendment @@ -4390,13 +4393,6 @@ public: { Env env{*this, features}; - auto const gw = Account("gw"); - auto const alice = Account("alice"); - auto const bob = Account("bob"); - auto const carol = Account("carol"); - auto const dan = Account("dan"); - auto const gwUSD = gw["USD"]; - env.fund(XRP(400000), gw, alice, bob, carol, dan); env.close(); @@ -4466,7 +4462,6 @@ public: env.close(); // Create new account eve without trustline - auto const eve = Account("eve"); env.fund(XRP(400000), eve); env.close();