ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove flow assert: (#5009)

Browse Source 
Rounding in the payment engine is causing an assert to sometimes fire
with "dust" amounts. This is causing issues when running debug builds of
rippled. This issue will be addressed, but the assert is no longer
serving its purpose.
This commit is contained in:
seelabs
2024-05-01 11:40:06 -04:00
parent dccf3f49ef
commit 5aa1106ba1
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/ripple/app/paths/impl/StrandFlow.h
View File

@@ -834,7 +834,13 @@ flow(
{
if (actualOut > outReq)
{
assert(0);
// Rounding in the payment engine is causing this assert to
// sometimes fire with "dust" amounts. This is causing issues when
// running debug builds of rippled. While this issue still needs to
// be resolved, the assert is causing more harm than good at this
// point.
// assert(0);
return {tefEXCEPTION, std::move(ofrsToRmOnFail)};
}
if (!partialPayment)