Merge branch 'develop' into mvadari/refactor-tx-settings

include/xrpl/basics/Buffer.h

@@ -3,6 +3,7 @@
 #include <xrpl/basics/Slice.h>
 #include <xrpl/beast/utility/instrumentation.h>
 
+#include <algorithm>
 #include <cstdint>
 #include <cstring>
 #include <memory>
@@ -156,6 +157,19 @@ public:
     }
     /** @} */
 
+    /**
+     * Set every byte in the buffer to the given value.
+     *
+     * The size is unchanged, and this is a no-op on an empty buffer.
+     *
+     * @param value the byte to write to every position.
+     */
+    void
+    fill(std::uint8_t value) noexcept
+    {
+        std::fill_n(p_.get(), size_, value);
+    }
+
     /**
      * Reset the buffer.
      * All memory is deallocated. The resulting size is 0.

include/xrpl/json/json_value.h

@@ -4,6 +4,7 @@
 #include <xrpl/json/json_forwards.h>
 
 #include <cstring>
+#include <iterator>
 #include <limits>
 #include <map>
 #include <string>
@@ -524,6 +525,7 @@ public:
 class ValueIteratorBase
 {
 public:
+    using iterator_category = std::bidirectional_iterator_tag;
     using size_t = unsigned int;
     using difference_type = int;
     using SelfType = ValueIteratorBase;

include/xrpl/tx/invariants/FreezeInvariant.h

@@ -69,7 +69,8 @@ private:
         IssuerChanges const& changes,
         STTx const& tx,
         beast::Journal const& j,
-        bool enforce);
+        bool enforce,
+        bool fixOverrideFreeze);
 
     static bool
     validateFrozenState(
@@ -78,7 +79,8 @@ private:
         STTx const& tx,
         beast::Journal const& j,
         bool enforce,
-        bool globalFreeze);
+        bool globalFreeze,
+        bool fixOverrideFreeze);
 };
 
 }  // namespace xrpl