ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-06-03 08:46:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Add simple clang-tidy readability checks (#6556)

Browse Source 
This change enables the following clang-tidy checks:
-  readability-avoid-nested-conditional-operator,
-  readability-avoid-return-with-void-value,
-  readability-braces-around-statements,
-  readability-const-return-type,
-  readability-container-contains,
-  readability-container-size-empty,
-  readability-else-after-return,
-  readability-make-member-function-const,
-  readability-redundant-casting,
-  readability-redundant-inline-specifier,
-  readability-redundant-member-init,
-  readability-redundant-string-init,
-  readability-reference-to-constructed-temporary,
-  readability-static-definition
This commit is contained in:
Alex Kremer
2026-03-18 16:41:49 +00:00
committed by GitHub
parent b92a9a3053
commit 57e4cbbcd9
328 changed files with 4415 additions and 1176 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/test/protocol/STAccount_test.cpp
View File

@@ -12,7 +12,7 @@ struct STAccount_test : public beast::unit_test::suite
// Test default constructor.
STAccount const defaultAcct;
BEAST_EXPECT(defaultAcct.getSType() == STI_ACCOUNT);
BEAST_EXPECT(defaultAcct.getText() == "");
BEAST_EXPECT(defaultAcct.getText().empty());
BEAST_EXPECT(defaultAcct.isDefault() == true);
BEAST_EXPECT(defaultAcct.value() == AccountID{});
{
@@ -38,7 +38,7 @@ struct STAccount_test : public beast::unit_test::suite
// Test constructor from SField.
STAccount const sfAcct{sfAccount};
BEAST_EXPECT(sfAcct.getSType() == STI_ACCOUNT);
BEAST_EXPECT(sfAcct.getText() == "");
BEAST_EXPECT(sfAcct.getText().empty());
BEAST_EXPECT(sfAcct.isDefault());
BEAST_EXPECT(sfAcct.value() == AccountID{});
BEAST_EXPECT(sfAcct.isEquivalent(defaultAcct));

6
src/test/protocol/STObject_test.cpp
View File

@@ -420,9 +420,9 @@ public:
STObject st(sot, sfGeneric);
auto const& cst(st);
BEAST_EXPECT(cst[sf1].size() == 0);
BEAST_EXPECT(cst[sf1].empty());
BEAST_EXPECT(!cst[~sf2]);
BEAST_EXPECT(cst[sf3].size() == 0);
BEAST_EXPECT(cst[sf3].empty());
std::vector<uint256> v;
v.emplace_back(1);
st[sf1] = v;
@@ -437,7 +437,7 @@ public:
BEAST_EXPECT(cst[sf3].size() == 1);
BEAST_EXPECT(cst[sf3][0] == uint256{1});
st[sf3] = std::vector<uint256>{};
BEAST_EXPECT(cst[sf3].size() == 0);
BEAST_EXPECT(cst[sf3].empty());
}
} // namespace xrpl

4
src/test/protocol/STParsedJSON_test.cpp
View File

@@ -894,7 +894,7 @@ class STParsedJSON_test : public beast::unit_test::suite
BEAST_EXPECT(obj.object->isFieldPresent(sfPublicKey));
auto const& blob =
obj.object->getFieldVL(sfPublicKey); // NOLINT(bugprone-unchecked-optional-access)
BEAST_EXPECT(blob.size() == 0);
BEAST_EXPECT(blob.empty());
}
// Test lowercase hex string for blob
@@ -975,7 +975,7 @@ class STParsedJSON_test : public beast::unit_test::suite
BEAST_EXPECT(obj.object->isFieldPresent(sfHashes));
auto const& vec =
obj.object->getFieldV256(sfHashes); // NOLINT(bugprone-unchecked-optional-access)
BEAST_EXPECT(vec.size() == 0);
BEAST_EXPECT(vec.empty());
}
// Test array with invalid hex string (should fail)

4
src/test/protocol/SecretKey_test.cpp
View File

@@ -112,7 +112,7 @@ public:
auto sig = signDigest(pk, sk, digest);
BEAST_EXPECT(sig.size() != 0);
BEAST_EXPECT(!sig.empty());
BEAST_EXPECT(verifyDigest(pk, digest, sig, true));
// Wrong digest:
@@ -150,7 +150,7 @@ public:
auto sig = sign(pk, sk, makeSlice(data));
BEAST_EXPECT(sig.size() != 0);
BEAST_EXPECT(!sig.empty());
BEAST_EXPECT(verify(pk, makeSlice(data), sig));
// Construct wrong data:

8
src/test/protocol/Seed_test.cpp
View File

@@ -120,7 +120,7 @@ public:
to_string(calcNodeID(publicKey)) == "7E59C17D50F5959C7B158FEC95C8F815BF653DC8");
auto sig = sign(publicKey, secretKey, makeSlice(message1));
BEAST_EXPECT(sig.size() != 0);
BEAST_EXPECT(!sig.empty());
BEAST_EXPECT(verify(publicKey, makeSlice(message1), sig));
// Correct public key but wrong message
@@ -162,7 +162,7 @@ public:
to_string(calcNodeID(publicKey)) == "AA066C988C712815CC37AF71472B7CBBBD4E2A0A");
auto sig = sign(publicKey, secretKey, makeSlice(message1));
BEAST_EXPECT(sig.size() != 0);
BEAST_EXPECT(!sig.empty());
BEAST_EXPECT(verify(publicKey, makeSlice(message1), sig));
// Correct public key but wrong message
@@ -202,7 +202,7 @@ public:
"p9JfM6HHi64m6mvB6v5k7G2b1cXzGmYiCNJf6GHPKvFTWdeRVjh");
auto sig = sign(pk, sk, makeSlice(message1));
BEAST_EXPECT(sig.size() != 0);
BEAST_EXPECT(!sig.empty());
BEAST_EXPECT(verify(pk, makeSlice(message1), sig));
// Correct public key but wrong message
@@ -241,7 +241,7 @@ public:
"pwDQjwEhbUBmPuEjFpEG75bFhv2obkCB7NxQsfFxM7xGHBMVPu9");
auto sig = sign(pk, sk, makeSlice(message1));
BEAST_EXPECT(sig.size() != 0);
BEAST_EXPECT(!sig.empty());
BEAST_EXPECT(verify(pk, makeSlice(message1), sig));
// Correct public key but wrong message