refactor: Add simple clang-tidy readability checks (#6556)

This change enables the following clang-tidy checks:
-  readability-avoid-nested-conditional-operator,
-  readability-avoid-return-with-void-value,
-  readability-braces-around-statements,
-  readability-const-return-type,
-  readability-container-contains,
-  readability-container-size-empty,
-  readability-else-after-return,
-  readability-make-member-function-const,
-  readability-redundant-casting,
-  readability-redundant-inline-specifier,
-  readability-redundant-member-init,
-  readability-redundant-string-init,
-  readability-reference-to-constructed-temporary,
-  readability-static-definition
This commit is contained in:
Alex Kremer
2026-03-18 16:41:49 +00:00
committed by GitHub
parent b92a9a3053
commit 57e4cbbcd9
328 changed files with 4415 additions and 1176 deletions

View File

@@ -58,7 +58,9 @@ mismatch(Ledger const& a, Ledger const& b)
count -= step + Seq{1};
}
else
{
count = step;
}
}
return start;
}
@@ -88,9 +90,13 @@ LedgerOracle::accept(
next.closeTimeResolution = closeTimeResolution;
next.closeTimeAgree = consensusCloseTime != NetClock::time_point{};
if (next.closeTimeAgree)
{
next.closeTime = effCloseTime(consensusCloseTime, closeTimeResolution, parent.closeTime());
}
else
{
next.closeTime = parent.closeTime() + 1s;
}
next.parentCloseTime = parent.closeTime();
next.parentID = parent.id();