ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-06-06 18:26:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Add simple clang-tidy readability checks (#6556)

Browse Source 
This change enables the following clang-tidy checks:
-  readability-avoid-nested-conditional-operator,
-  readability-avoid-return-with-void-value,
-  readability-braces-around-statements,
-  readability-const-return-type,
-  readability-container-contains,
-  readability-container-size-empty,
-  readability-else-after-return,
-  readability-make-member-function-const,
-  readability-redundant-casting,
-  readability-redundant-inline-specifier,
-  readability-redundant-member-init,
-  readability-redundant-string-init,
-  readability-reference-to-constructed-temporary,
-  readability-static-definition
This commit is contained in:
Alex Kremer
2026-03-18 16:41:49 +00:00
committed by GitHub
parent b92a9a3053
commit 57e4cbbcd9
328 changed files with 4415 additions and 1176 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
src/test/app/Vault_test.cpp
View File

@@ -66,15 +66,23 @@ class Vault_test : public beast::unit_test::suite
auto const vault = env.le(keylet);
BEAST_EXPECT(vault != nullptr);
if (!asset.integral())
{
BEAST_EXPECT(vault->at(sfScale) == 6);
}
else
{
BEAST_EXPECT(vault->at(sfScale) == 0);
}
auto const shares = env.le(keylet::mptIssuance(vault->at(sfShareMPTID)));
BEAST_EXPECT(shares != nullptr);
if (!asset.integral())
{
BEAST_EXPECT(shares->at(sfAssetScale) == 6);
}
else
{
BEAST_EXPECT(shares->at(sfAssetScale) == 0);
}
return {MPTIssue(vault->at(sfShareMPTID)), Account("vault", vault->at(sfAccount))};
}();
auto const shares = share.raw().get<MPTIssue>();
@@ -1330,11 +1338,17 @@ class Vault_test : public beast::unit_test::suite
BEAST_EXPECT(asset1 <= toFund1 && asset2 <= toFund2);
if (!asset1.native() && !asset2.native())
{
fund(env, gw, {alice, carol}, {toFund1, toFund2}, Fund::All);
}
else if (asset1.native())
{
fund(env, gw, {alice, carol}, toFund1, {toFund2}, Fund::All);
}
else if (asset2.native())
{
fund(env, gw, {alice, carol}, toFund2, {toFund1}, Fund::All);
}
AMM ammAlice(env, alice, asset1, asset2, CreateArg{.log = false, .tfee = 0});
@@ -2276,7 +2290,9 @@ class Vault_test : public beast::unit_test::suite
env(fset(issuer, asfDefaultRipple));
}
else
{
env.trust(asset(1000), charlie);
}
env.close();
env(rate(issuer, args.transferRate));
env.close();
@@ -4605,18 +4621,23 @@ class Vault_test : public beast::unit_test::suite
{
testcase("VaultClawback (share) - " + prefix + " owner asset clawback fails");
auto [vault, vaultKeylet] = setupVault(asset, owner, depositor);
// when asset is XRP or owner is not issuer clawback fail
// when owner is issuer precision loss occurs as vault is
// empty
auto const expectedTer = [&]() {
if (asset.native())
return ter(temMALFORMED);
if (asset.raw().getIssuer() != owner.id())
return ter(tecNO_PERMISSION);
return ter(tecPRECISION_LOSS);
}();
env(vault.clawback({
.issuer = owner,
.id = vaultKeylet.key,
.holder = depositor,
.amount = asset(100).value(),
}),
// when asset is XRP or owner is not issuer clawback fail
// when owner is issuer precision loss occurs as vault is
// empty
asset.native() ? ter(temMALFORMED)
: asset.raw().getIssuer() != owner.id() ? ter(tecNO_PERMISSION)
: ter(tecPRECISION_LOSS));
expectedTer);
env.close();
}