ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-04-29 15:37:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Add simple clang-tidy readability checks (#6556)

Browse Source 
This change enables the following clang-tidy checks:
-  readability-avoid-nested-conditional-operator,
-  readability-avoid-return-with-void-value,
-  readability-braces-around-statements,
-  readability-const-return-type,
-  readability-container-contains,
-  readability-container-size-empty,
-  readability-else-after-return,
-  readability-make-member-function-const,
-  readability-redundant-casting,
-  readability-redundant-inline-specifier,
-  readability-redundant-member-init,
-  readability-redundant-string-init,
-  readability-reference-to-constructed-temporary,
-  readability-static-definition
This commit is contained in:
Alex Kremer
2026-03-18 16:41:49 +00:00
committed by GitHub
parent b92a9a3053
commit 57e4cbbcd9
328 changed files with 4415 additions and 1176 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/test/app/NFToken_test.cpp
View File

@@ -171,7 +171,9 @@ class NFTokenBaseUtil_test : public beast::unit_test::suite
int line) {
auto oneCheck = [line, this](char const* type, std::uint32_t found, std::uint32_t exp) {
if (found == exp)
{
pass();
}
else
{
std::stringstream ss;
@@ -269,7 +271,9 @@ class NFTokenBaseUtil_test : public beast::unit_test::suite
auto oneCheck =
[this](char const* type, std::uint32_t found, std::uint32_t exp, int line) {
if (found == exp)
{
pass();
}
else
{
std::stringstream ss;
@@ -2171,9 +2175,13 @@ class NFTokenBaseUtil_test : public beast::unit_test::suite
for (auto NumberSwitchOver : {true})
{
if (NumberSwitchOver)
{
env.enableFeature(fixUniversalNumber);
}
else
{
env.disableFeature(fixUniversalNumber);
}
// An nft with a transfer fee of 1 basis point.
uint256 const nftID = token::getNextID(env, alice, 0u, tfTransferable, 1);
@@ -2347,7 +2355,9 @@ class NFTokenBaseUtil_test : public beast::unit_test::suite
auto check = [this](std::uint32_t taxon, uint256 const& nftID) {
nft::Taxon const gotTaxon = nft::getTaxon(nftID);
if (nft::toTaxon(taxon) == gotTaxon)
{
pass();
}
else
{
std::stringstream ss;
@@ -4791,7 +4801,9 @@ class NFTokenBaseUtil_test : public beast::unit_test::suite
env(pay(secondarySeller, gw, env.balance(secondarySeller, gwXPB)));
auto brokerDiff = gwXAU(5000) - env.balance(broker, gwXAU);
if (brokerDiff > gwXAU(0))
{
env(pay(gw, broker, brokerDiff));
}
else if (brokerDiff < gwXAU(0))
{
brokerDiff.negate();
@@ -6976,7 +6988,9 @@ class NFTokenBaseUtil_test : public beast::unit_test::suite
auto checkURI = [&accountNFTs, this](Account const& acct, char const* uri, int line) {
auto const nfts = accountNFTs(acct);
if (nfts.size() == 1)
{
pass();
}
else
{
std::ostringstream text;
@@ -6988,7 +7002,9 @@ class NFTokenBaseUtil_test : public beast::unit_test::suite
if (uri == nullptr)
{
if (!nfts[0u].isMember(sfURI.jsonName))
{
pass();
}
else
{
std::ostringstream text;
@@ -6999,7 +7015,9 @@ class NFTokenBaseUtil_test : public beast::unit_test::suite
}
if (nfts[0u][sfURI.jsonName] == strHex(std::string(uri)))
{
pass();
}
else
{
std::ostringstream text;