refactor: Add simple clang-tidy readability checks (#6556)

This change enables the following clang-tidy checks:
-  readability-avoid-nested-conditional-operator,
-  readability-avoid-return-with-void-value,
-  readability-braces-around-statements,
-  readability-const-return-type,
-  readability-container-contains,
-  readability-container-size-empty,
-  readability-else-after-return,
-  readability-make-member-function-const,
-  readability-redundant-casting,
-  readability-redundant-inline-specifier,
-  readability-redundant-member-init,
-  readability-redundant-string-init,
-  readability-reference-to-constructed-temporary,
-  readability-static-definition
This commit is contained in:
Alex Kremer
2026-03-18 16:41:49 +00:00
committed by GitHub
parent b92a9a3053
commit 57e4cbbcd9
328 changed files with 4415 additions and 1176 deletions

View File

@@ -196,6 +196,7 @@ struct Flow_test : public beast::unit_test::suite
// Dan -> Bob -> Alice -> Carol; vary bobDanQIn and bobAliceQOut
for (auto bobDanQIn : {80, 100, 120})
{
for (auto bobAliceQOut : {80, 100, 120})
{
Env env(*this, features);
@@ -213,12 +214,17 @@ struct Flow_test : public beast::unit_test::suite
txflags(tfNoRippleDirect));
env.require(balance(bob, USDA(90)));
if (bobAliceQOut > bobDanQIn)
{
env.require(
balance(bob, USDD(10.0 * double(bobAliceQOut) / double(bobDanQIn))));
}
else
{
env.require(balance(bob, USDD(10)));
}
env.require(balance(carol, USDA(10)));
}
}
// bob -> alice -> carol; vary carolAliceQIn
for (auto carolAliceQIn : {80, 100, 120})
@@ -472,8 +478,10 @@ struct Flow_test : public beast::unit_test::suite
return false;
Sandbox sb(&view, tapNONE);
for (auto const& o : flowResult.removableOffers)
{
if (auto ok = sb.peek(keylet::offer(o)))
offerDelete(sb, ok, flowJournal);
}
sb.apply(view);
return true;
});