mirror of
https://github.com/XRPLF/rippled.git
synced 2026-06-04 01:06:48 +00:00
refactor: Add simple clang-tidy readability checks (#6556)
This change enables the following clang-tidy checks: - readability-avoid-nested-conditional-operator, - readability-avoid-return-with-void-value, - readability-braces-around-statements, - readability-const-return-type, - readability-container-contains, - readability-container-size-empty, - readability-else-after-return, - readability-make-member-function-const, - readability-redundant-casting, - readability-redundant-inline-specifier, - readability-redundant-member-init, - readability-redundant-string-init, - readability-reference-to-constructed-temporary, - readability-static-definition
This commit is contained in:
@@ -196,6 +196,7 @@ struct Flow_test : public beast::unit_test::suite
|
||||
|
||||
// Dan -> Bob -> Alice -> Carol; vary bobDanQIn and bobAliceQOut
|
||||
for (auto bobDanQIn : {80, 100, 120})
|
||||
{
|
||||
for (auto bobAliceQOut : {80, 100, 120})
|
||||
{
|
||||
Env env(*this, features);
|
||||
@@ -213,12 +214,17 @@ struct Flow_test : public beast::unit_test::suite
|
||||
txflags(tfNoRippleDirect));
|
||||
env.require(balance(bob, USDA(90)));
|
||||
if (bobAliceQOut > bobDanQIn)
|
||||
{
|
||||
env.require(
|
||||
balance(bob, USDD(10.0 * double(bobAliceQOut) / double(bobDanQIn))));
|
||||
}
|
||||
else
|
||||
{
|
||||
env.require(balance(bob, USDD(10)));
|
||||
}
|
||||
env.require(balance(carol, USDA(10)));
|
||||
}
|
||||
}
|
||||
|
||||
// bob -> alice -> carol; vary carolAliceQIn
|
||||
for (auto carolAliceQIn : {80, 100, 120})
|
||||
@@ -472,8 +478,10 @@ struct Flow_test : public beast::unit_test::suite
|
||||
return false;
|
||||
Sandbox sb(&view, tapNONE);
|
||||
for (auto const& o : flowResult.removableOffers)
|
||||
{
|
||||
if (auto ok = sb.peek(keylet::offer(o)))
|
||||
offerDelete(sb, ok, flowJournal);
|
||||
}
|
||||
sb.apply(view);
|
||||
return true;
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user