ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-06-03 08:46:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Add simple clang-tidy readability checks (#6556)

Browse Source 
This change enables the following clang-tidy checks:
-  readability-avoid-nested-conditional-operator,
-  readability-avoid-return-with-void-value,
-  readability-braces-around-statements,
-  readability-const-return-type,
-  readability-container-contains,
-  readability-container-size-empty,
-  readability-else-after-return,
-  readability-make-member-function-const,
-  readability-redundant-casting,
-  readability-redundant-inline-specifier,
-  readability-redundant-member-init,
-  readability-redundant-string-init,
-  readability-reference-to-constructed-temporary,
-  readability-static-definition
This commit is contained in:
Alex Kremer
2026-03-18 16:41:49 +00:00
committed by GitHub
parent b92a9a3053
commit 57e4cbbcd9
328 changed files with 4415 additions and 1176 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
src/test/app/Check_test.cpp
View File

@@ -528,8 +528,8 @@ class Check_test : public beast::unit_test::suite
env.close();
env.require(balance(alice, startBalance - XRP(10) - drops(baseFeeDrops)));
env.require(balance(bob, startBalance + XRP(10) - drops(baseFeeDrops)));
BEAST_EXPECT(checksOnAccount(env, alice).size() == 0);
BEAST_EXPECT(checksOnAccount(env, bob).size() == 0);
BEAST_EXPECT(checksOnAccount(env, alice).empty());
BEAST_EXPECT(checksOnAccount(env, bob).empty());
BEAST_EXPECT(ownerCount(env, alice) == 0);
BEAST_EXPECT(ownerCount(env, bob) == 0);
@@ -562,8 +562,8 @@ class Check_test : public beast::unit_test::suite
verifyDeliveredAmount(env, drops(checkAmount.mantissa()));
env.require(balance(alice, reserve));
env.require(balance(bob, startBalance + checkAmount - drops(baseFeeDrops * 3)));
BEAST_EXPECT(checksOnAccount(env, alice).size() == 0);
BEAST_EXPECT(checksOnAccount(env, bob).size() == 0);
BEAST_EXPECT(checksOnAccount(env, alice).empty());
BEAST_EXPECT(checksOnAccount(env, bob).empty());
BEAST_EXPECT(ownerCount(env, alice) == 0);
BEAST_EXPECT(ownerCount(env, bob) == 0);
@@ -592,8 +592,8 @@ class Check_test : public beast::unit_test::suite
verifyDeliveredAmount(env, drops(checkAmount.mantissa() - 1));
env.require(balance(alice, reserve));
env.require(balance(bob, startBalance + checkAmount - drops(baseFeeDrops * 2 + 1)));
BEAST_EXPECT(checksOnAccount(env, alice).size() == 0);
BEAST_EXPECT(checksOnAccount(env, bob).size() == 0);
BEAST_EXPECT(checksOnAccount(env, alice).empty());
BEAST_EXPECT(checksOnAccount(env, bob).empty());
BEAST_EXPECT(ownerCount(env, alice) == 0);
BEAST_EXPECT(ownerCount(env, bob) == 0);
@@ -663,8 +663,8 @@ class Check_test : public beast::unit_test::suite
env.close();
env.require(balance(alice, USD(0)));
env.require(balance(bob, USD(10)));
BEAST_EXPECT(checksOnAccount(env, alice).size() == 0);
BEAST_EXPECT(checksOnAccount(env, bob).size() == 0);
BEAST_EXPECT(checksOnAccount(env, alice).empty());
BEAST_EXPECT(checksOnAccount(env, bob).empty());
BEAST_EXPECT(ownerCount(env, alice) == 1);
BEAST_EXPECT(ownerCount(env, bob) == 1);
@@ -688,8 +688,8 @@ class Check_test : public beast::unit_test::suite
env.close();
env.require(balance(alice, USD(2)));
env.require(balance(bob, USD(8)));
BEAST_EXPECT(checksOnAccount(env, alice).size() == 0);
BEAST_EXPECT(checksOnAccount(env, bob).size() == 0);
BEAST_EXPECT(checksOnAccount(env, alice).empty());
BEAST_EXPECT(checksOnAccount(env, bob).empty());
BEAST_EXPECT(ownerCount(env, alice) == 1);
BEAST_EXPECT(ownerCount(env, bob) == 1);
@@ -755,8 +755,8 @@ class Check_test : public beast::unit_test::suite
env.close();
env.require(balance(alice, USD(0)));
env.require(balance(bob, USD(10)));
BEAST_EXPECT(checksOnAccount(env, alice).size() == 0);
BEAST_EXPECT(checksOnAccount(env, bob).size() == 0);
BEAST_EXPECT(checksOnAccount(env, alice).empty());
BEAST_EXPECT(checksOnAccount(env, bob).empty());
BEAST_EXPECT(ownerCount(env, alice) == 1);
BEAST_EXPECT(ownerCount(env, bob) == 1);
}
@@ -838,8 +838,8 @@ class Check_test : public beast::unit_test::suite
verifyDeliveredAmount(env, USD(2));
env.require(balance(alice, USD(0)));
env.require(balance(bob, USD(8)));
BEAST_EXPECT(checksOnAccount(env, alice).size() == 0);
BEAST_EXPECT(checksOnAccount(env, bob).size() == 0);
BEAST_EXPECT(checksOnAccount(env, alice).empty());
BEAST_EXPECT(checksOnAccount(env, bob).empty());
BEAST_EXPECT(ownerCount(env, alice) == 1);
BEAST_EXPECT(ownerCount(env, bob) == 1);
}
@@ -890,8 +890,8 @@ class Check_test : public beast::unit_test::suite
env.require(balance(alice, USD(8) - bobGot));
env.require(balance(bob, bobGot));
BEAST_EXPECT(checksOnAccount(env, alice).size() == 0);
BEAST_EXPECT(checksOnAccount(env, bob).size() == 0);
BEAST_EXPECT(checksOnAccount(env, alice).empty());
BEAST_EXPECT(checksOnAccount(env, bob).empty());
BEAST_EXPECT(ownerCount(env, alice) == 1);
BEAST_EXPECT(ownerCount(env, bob) == 1);
}
@@ -945,8 +945,8 @@ class Check_test : public beast::unit_test::suite
env.close();
env.require(balance(alice, USD(5)));
env.require(balance(bob, USD(3)));
BEAST_EXPECT(checksOnAccount(env, alice).size() == 0);
BEAST_EXPECT(checksOnAccount(env, bob).size() == 0);
BEAST_EXPECT(checksOnAccount(env, alice).empty());
BEAST_EXPECT(checksOnAccount(env, bob).empty());
BEAST_EXPECT(ownerCount(env, alice) == 1);
BEAST_EXPECT(ownerCount(env, bob) == 2);
}
@@ -1018,8 +1018,8 @@ class Check_test : public beast::unit_test::suite
env.close();
env.require(balance(alice, USD(1000 - 125 - 60)));
env.require(balance(bob, USD(0 + 100 + 50)));
BEAST_EXPECT(checksOnAccount(env, alice).size() == 0);
BEAST_EXPECT(checksOnAccount(env, bob).size() == 0);
BEAST_EXPECT(checksOnAccount(env, alice).empty());
BEAST_EXPECT(checksOnAccount(env, bob).empty());
}
void
@@ -1655,7 +1655,7 @@ class Check_test : public beast::unit_test::suite
env(check::cancel(bob, chkIdNotExp3));
env.close();
BEAST_EXPECT(checksOnAccount(env, alice).size() == 0);
BEAST_EXPECT(checksOnAccount(env, alice).empty());
BEAST_EXPECT(ownerCount(env, alice) == 1);
}
}
@@ -1815,7 +1815,7 @@ class Check_test : public beast::unit_test::suite
env.require(owners(alice, 6));
env.require(tickets(alice, env.seq(alice) - aliceTicketSeq));
BEAST_EXPECT(checksOnAccount(env, alice).size() == 0);
BEAST_EXPECT(checksOnAccount(env, alice).empty());
BEAST_EXPECT(env.seq(alice) == aliceSeq);
env.require(balance(alice, USD(700)));
@@ -1852,7 +1852,7 @@ class Check_test : public beast::unit_test::suite
}
// Operators to make using the class more convenient.
operator Account const() const
operator Account() const
{
return acct;
}