ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-06-04 17:27:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Add simple clang-tidy readability checks (#6556)

Browse Source 
This change enables the following clang-tidy checks:
-  readability-avoid-nested-conditional-operator,
-  readability-avoid-return-with-void-value,
-  readability-braces-around-statements,
-  readability-const-return-type,
-  readability-container-contains,
-  readability-container-size-empty,
-  readability-else-after-return,
-  readability-make-member-function-const,
-  readability-redundant-casting,
-  readability-redundant-inline-specifier,
-  readability-redundant-member-init,
-  readability-redundant-string-init,
-  readability-reference-to-constructed-temporary,
-  readability-static-definition
This commit is contained in:
Alex Kremer
2026-03-18 16:41:49 +00:00
committed by GitHub
parent b92a9a3053
commit 57e4cbbcd9
328 changed files with 4415 additions and 1176 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/test/app/AmendmentTable_test.cpp
View File

@@ -390,7 +390,7 @@ public:
{
uint256 const supportedID = amendmentId(a);
bool const enabled = table->isEnabled(supportedID);
bool const found = allEnabled.find(supportedID) != allEnabled.end();
bool const found = allEnabled.contains(supportedID);
BEAST_EXPECTS(
enabled == found,
a + (enabled ? " enabled " : " disabled ") + (found ? " found" : " not found"));
@@ -404,7 +404,7 @@ public:
std::vector<uint256> const desired = table->getDesired();
for (uint256 const& a : desired)
BEAST_EXPECT(vetoed.count(a) == 0);
BEAST_EXPECT(not vetoed.contains(a));
// Unveto an amendment that is already not vetoed. Shouldn't
// hurt anything, but the values returned by getDesired()
@@ -526,22 +526,22 @@ public:
{
case 0:
// amendment goes from majority to enabled
if (enabled.find(hash) != enabled.end())
if (enabled.contains(hash))
Throw<std::runtime_error>("enabling already enabled");
if (majority.find(hash) == majority.end())
if (!majority.contains(hash))
Throw<std::runtime_error>("enabling without majority");
enabled.insert(hash);
majority.erase(hash);
break;
case tfGotMajority:
if (majority.find(hash) != majority.end())
if (majority.contains(hash))
Throw<std::runtime_error>("got majority while having majority");
majority[hash] = roundTime;
break;
case tfLostMajority:
if (majority.find(hash) == majority.end())
if (!majority.contains(hash))
Throw<std::runtime_error>("lost majority without majority");
majority.erase(hash);
break;
@@ -719,7 +719,7 @@ public:
BEAST_EXPECT(ourVotes.size() == yes_.size());
BEAST_EXPECT(enabled.empty());
for (auto const& i : yes_)
BEAST_EXPECT(majority.find(amendmentId(i)) == majority.end());
BEAST_EXPECT(not majority.contains(amendmentId(i)));
// Now, everyone votes for this feature
for (auto const& i : yes_)
@@ -766,7 +766,7 @@ public:
BEAST_EXPECT(enabled.size() == yes_.size());
BEAST_EXPECT(ourVotes.empty());
for (auto const& i : yes_)
BEAST_EXPECT(majority.find(amendmentId(i)) == majority.end());
BEAST_EXPECT(not majority.contains(amendmentId(i)));
}
// Detect majority at 80%, enable later