Review feedback

This commit is contained in:
Bronek Kozicki
2025-11-11 10:01:07 +00:00
parent ab435b7595
commit 570874ef1d
2 changed files with 6 additions and 6 deletions

View File

@@ -109,7 +109,7 @@
# - add a new function add_code_coverage_to_target # - add a new function add_code_coverage_to_target
# - remove some unused code # - remove some unused code
# #
# 2025-11-10, Bronek Kozicki # 2025-11-11, Bronek Kozicki
# - make EXECUTABLE and EXECUTABLE_ARGS optional # - make EXECUTABLE and EXECUTABLE_ARGS optional
# #
# USAGE: # USAGE:
@@ -405,21 +405,18 @@ function(setup_target_for_coverage_gcovr)
endforeach() endforeach()
# Set up commands which will be run to generate coverage data # Set up commands which will be run to generate coverage data
# Run tests # If EXECUTABLE is not set, the user is expected to run the tests manually
# before running the coverage target NAME
if(DEFINED Coverage_EXECUTABLE) if(DEFINED Coverage_EXECUTABLE)
set(GCOVR_EXEC_TESTS_CMD set(GCOVR_EXEC_TESTS_CMD
${Coverage_EXECUTABLE} ${Coverage_EXECUTABLE_ARGS} ${Coverage_EXECUTABLE} ${Coverage_EXECUTABLE_ARGS}
) )
else()
set(GCOVR_EXEC_TESTS_CMD echo) # dummy
endif() endif()
# Create folder # Create folder
if(DEFINED GCOVR_CREATE_FOLDER) if(DEFINED GCOVR_CREATE_FOLDER)
set(GCOVR_FOLDER_CMD set(GCOVR_FOLDER_CMD
${CMAKE_COMMAND} -E make_directory ${GCOVR_CREATE_FOLDER}) ${CMAKE_COMMAND} -E make_directory ${GCOVR_CREATE_FOLDER})
else()
set(GCOVR_FOLDER_CMD echo) # dummy
endif() endif()
# Running gcovr # Running gcovr

View File

@@ -11,6 +11,9 @@ if(CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
return() return()
endif() endif()
include(ProcessorCount)
ProcessorCount(PROCESSOR_COUNT)
include(CodeCoverage) include(CodeCoverage)
# The instructions for these commands come from the `CodeCoverage` module, # The instructions for these commands come from the `CodeCoverage` module,