diff --git a/src/libxrpl/tx/invariants/InvariantCheck.cpp b/src/libxrpl/tx/invariants/InvariantCheck.cpp index ea36869fb7..6859a6ae8a 100644 --- a/src/libxrpl/tx/invariants/InvariantCheck.cpp +++ b/src/libxrpl/tx/invariants/InvariantCheck.cpp @@ -11,15 +11,14 @@ #include #include #include -#include #include #include #include #include #include #include +#include #include -#include #include #include // IWYU pragma: keep #include @@ -960,8 +959,8 @@ hasConstantFieldChanged(STObject const& before, STObject const& after, SOTemplat auto const* bField = before.peekAtPField(sf); auto const* aField = after.peekAtPField(sf); - bool const bPresent = bField && bField->getSType() != STI_NOTPRESENT; - bool const aPresent = aField && aField->getSType() != STI_NOTPRESENT; + bool const bPresent = (bField != nullptr) && bField->getSType() != STI_NOTPRESENT; + bool const aPresent = (aField != nullptr) && aField->getSType() != STI_NOTPRESENT; XRPL_ASSERT( constant != soeCONSTANTINVALID, "xrpl::hasConstantFieldChanged : constant is invalid"); @@ -1016,7 +1015,7 @@ NoModifiedUnmodifiableFields::finalize( bool bad = false; { auto const* format = LedgerFormats::getInstance().findByType(type); - if (format) + if (format != nullptr) bad = hasConstantFieldChanged(*before, *after, format->getSOTemplate()); // sfLedgerIndex is a non-serialized (discardable) field