mirror of
https://github.com/XRPLF/rippled.git
synced 2025-12-06 17:27:55 +00:00
Format first-party source according to .clang-format
This commit is contained in:
Pretty Printer
committed by
manojsdoshi
manojsdoshi
parent
65dfc5d19e
commit
50760c6935
@@ -25,107 +25,110 @@ namespace test {
|
||||
|
||||
// Helper function that returns the reserve on an account based on
|
||||
// the passed in number of owners.
|
||||
static XRPAmount reserve (jtx::Env& env, std::uint32_t count)
|
||||
static XRPAmount
|
||||
reserve(jtx::Env& env, std::uint32_t count)
|
||||
{
|
||||
return env.current()->fees().accountReserve (count);
|
||||
return env.current()->fees().accountReserve(count);
|
||||
}
|
||||
|
||||
// Helper function that returns true if acct has the lsfDepostAuth flag set.
|
||||
static bool hasDepositAuth (jtx::Env const& env, jtx::Account const& acct)
|
||||
static bool
|
||||
hasDepositAuth(jtx::Env const& env, jtx::Account const& acct)
|
||||
{
|
||||
return ((*env.le(acct))[sfFlags] & lsfDepositAuth) == lsfDepositAuth;
|
||||
}
|
||||
|
||||
|
||||
struct DepositAuth_test : public beast::unit_test::suite
|
||||
{
|
||||
void testEnable()
|
||||
void
|
||||
testEnable()
|
||||
{
|
||||
testcase ("Enable");
|
||||
testcase("Enable");
|
||||
|
||||
using namespace jtx;
|
||||
Account const alice {"alice"};
|
||||
Account const alice{"alice"};
|
||||
|
||||
{
|
||||
// featureDepositAuth is disabled.
|
||||
Env env (*this, supported_amendments() - featureDepositAuth);
|
||||
env.fund (XRP (10000), alice);
|
||||
Env env(*this, supported_amendments() - featureDepositAuth);
|
||||
env.fund(XRP(10000), alice);
|
||||
|
||||
// Note that, to support old behavior, invalid flags are ignored.
|
||||
env (fset (alice, asfDepositAuth));
|
||||
env(fset(alice, asfDepositAuth));
|
||||
env.close();
|
||||
BEAST_EXPECT (! hasDepositAuth (env, alice));
|
||||
BEAST_EXPECT(!hasDepositAuth(env, alice));
|
||||
|
||||
env (fclear (alice, asfDepositAuth));
|
||||
env(fclear(alice, asfDepositAuth));
|
||||
env.close();
|
||||
BEAST_EXPECT (! hasDepositAuth (env, alice));
|
||||
BEAST_EXPECT(!hasDepositAuth(env, alice));
|
||||
}
|
||||
{
|
||||
// featureDepositAuth is enabled.
|
||||
Env env (*this);
|
||||
env.fund (XRP (10000), alice);
|
||||
Env env(*this);
|
||||
env.fund(XRP(10000), alice);
|
||||
|
||||
env (fset (alice, asfDepositAuth));
|
||||
env(fset(alice, asfDepositAuth));
|
||||
env.close();
|
||||
BEAST_EXPECT (hasDepositAuth (env, alice));
|
||||
BEAST_EXPECT(hasDepositAuth(env, alice));
|
||||
|
||||
env (fclear (alice, asfDepositAuth));
|
||||
env(fclear(alice, asfDepositAuth));
|
||||
env.close();
|
||||
BEAST_EXPECT (! hasDepositAuth (env, alice));
|
||||
BEAST_EXPECT(!hasDepositAuth(env, alice));
|
||||
}
|
||||
}
|
||||
|
||||
void testPayIOU()
|
||||
void
|
||||
testPayIOU()
|
||||
{
|
||||
// Exercise IOU payments and non-direct XRP payments to an account
|
||||
// that has the lsfDepositAuth flag set.
|
||||
testcase ("Pay IOU");
|
||||
testcase("Pay IOU");
|
||||
|
||||
using namespace jtx;
|
||||
Account const alice {"alice"};
|
||||
Account const bob {"bob"};
|
||||
Account const carol {"carol"};
|
||||
Account const gw {"gw"};
|
||||
Account const alice{"alice"};
|
||||
Account const bob{"bob"};
|
||||
Account const carol{"carol"};
|
||||
Account const gw{"gw"};
|
||||
IOU const USD = gw["USD"];
|
||||
|
||||
Env env (*this);
|
||||
Env env(*this);
|
||||
|
||||
env.fund (XRP (10000), alice, bob, carol, gw);
|
||||
env.trust (USD (1000), alice, bob);
|
||||
env.fund(XRP(10000), alice, bob, carol, gw);
|
||||
env.trust(USD(1000), alice, bob);
|
||||
env.close();
|
||||
|
||||
env (pay (gw, alice, USD (150)));
|
||||
env (offer (carol, USD(100), XRP(100)));
|
||||
env(pay(gw, alice, USD(150)));
|
||||
env(offer(carol, USD(100), XRP(100)));
|
||||
env.close();
|
||||
|
||||
// Make sure bob's trust line is all set up so he can receive USD.
|
||||
env (pay (alice, bob, USD (50)));
|
||||
env(pay(alice, bob, USD(50)));
|
||||
env.close();
|
||||
|
||||
// bob sets the lsfDepositAuth flag.
|
||||
env (fset (bob, asfDepositAuth), require(flags (bob, asfDepositAuth)));
|
||||
env(fset(bob, asfDepositAuth), require(flags(bob, asfDepositAuth)));
|
||||
env.close();
|
||||
|
||||
// None of the following payments should succeed.
|
||||
auto failedIouPayments = [this, &env, &alice, &bob, &USD] ()
|
||||
{
|
||||
env.require (flags (bob, asfDepositAuth));
|
||||
auto failedIouPayments = [this, &env, &alice, &bob, &USD]() {
|
||||
env.require(flags(bob, asfDepositAuth));
|
||||
|
||||
// Capture bob's balances before hand to confirm they don't change.
|
||||
PrettyAmount const bobXrpBalance {env.balance (bob, XRP)};
|
||||
PrettyAmount const bobUsdBalance {env.balance (bob, USD)};
|
||||
PrettyAmount const bobXrpBalance{env.balance(bob, XRP)};
|
||||
PrettyAmount const bobUsdBalance{env.balance(bob, USD)};
|
||||
|
||||
env (pay (alice, bob, USD (50)), ter (tecNO_PERMISSION));
|
||||
env(pay(alice, bob, USD(50)), ter(tecNO_PERMISSION));
|
||||
env.close();
|
||||
|
||||
// Note that even though alice is paying bob in XRP, the payment
|
||||
// is still not allowed since the payment passes through an offer.
|
||||
env (pay (alice, bob, drops(1)),
|
||||
sendmax (USD (1)), ter (tecNO_PERMISSION));
|
||||
env(pay(alice, bob, drops(1)),
|
||||
sendmax(USD(1)),
|
||||
ter(tecNO_PERMISSION));
|
||||
env.close();
|
||||
|
||||
BEAST_EXPECT (bobXrpBalance == env.balance (bob, XRP));
|
||||
BEAST_EXPECT (bobUsdBalance == env.balance (bob, USD));
|
||||
BEAST_EXPECT(bobXrpBalance == env.balance(bob, XRP));
|
||||
BEAST_EXPECT(bobUsdBalance == env.balance(bob, USD));
|
||||
};
|
||||
|
||||
// Test when bob has an XRP balance > base reserve.
|
||||
@@ -133,208 +136,205 @@ struct DepositAuth_test : public beast::unit_test::suite
|
||||
|
||||
// Set bob's XRP balance == base reserve. Also demonstrate that
|
||||
// bob can make payments while his lsfDepositAuth flag is set.
|
||||
env (pay (bob, alice, USD(25)));
|
||||
env(pay(bob, alice, USD(25)));
|
||||
env.close();
|
||||
|
||||
{
|
||||
STAmount const bobPaysXRP {
|
||||
env.balance (bob, XRP) - reserve (env, 1)};
|
||||
XRPAmount const bobPaysFee {reserve (env, 1) - reserve (env, 0)};
|
||||
env (pay (bob, alice, bobPaysXRP), fee (bobPaysFee));
|
||||
STAmount const bobPaysXRP{env.balance(bob, XRP) - reserve(env, 1)};
|
||||
XRPAmount const bobPaysFee{reserve(env, 1) - reserve(env, 0)};
|
||||
env(pay(bob, alice, bobPaysXRP), fee(bobPaysFee));
|
||||
env.close();
|
||||
}
|
||||
|
||||
// Test when bob's XRP balance == base reserve.
|
||||
BEAST_EXPECT (env.balance (bob, XRP) == reserve (env, 0));
|
||||
BEAST_EXPECT (env.balance (bob, USD) == USD(25));
|
||||
BEAST_EXPECT(env.balance(bob, XRP) == reserve(env, 0));
|
||||
BEAST_EXPECT(env.balance(bob, USD) == USD(25));
|
||||
failedIouPayments();
|
||||
|
||||
// Test when bob has an XRP balance == 0.
|
||||
env (noop (bob), fee (reserve (env, 0)));
|
||||
env.close ();
|
||||
env(noop(bob), fee(reserve(env, 0)));
|
||||
env.close();
|
||||
|
||||
BEAST_EXPECT (env.balance (bob, XRP) == XRP (0));
|
||||
BEAST_EXPECT(env.balance(bob, XRP) == XRP(0));
|
||||
failedIouPayments();
|
||||
|
||||
// Give bob enough XRP for the fee to clear the lsfDepositAuth flag.
|
||||
env (pay (alice, bob, drops(env.current()->fees().base)));
|
||||
env(pay(alice, bob, drops(env.current()->fees().base)));
|
||||
|
||||
// bob clears the lsfDepositAuth and the next payment succeeds.
|
||||
env (fclear (bob, asfDepositAuth));
|
||||
env(fclear(bob, asfDepositAuth));
|
||||
env.close();
|
||||
|
||||
env (pay (alice, bob, USD (50)));
|
||||
env(pay(alice, bob, USD(50)));
|
||||
env.close();
|
||||
|
||||
env (pay (alice, bob, drops(1)), sendmax (USD (1)));
|
||||
env(pay(alice, bob, drops(1)), sendmax(USD(1)));
|
||||
env.close();
|
||||
}
|
||||
|
||||
void testPayXRP()
|
||||
void
|
||||
testPayXRP()
|
||||
{
|
||||
// Exercise direct XRP payments to an account that has the
|
||||
// lsfDepositAuth flag set.
|
||||
testcase ("Pay XRP");
|
||||
testcase("Pay XRP");
|
||||
|
||||
using namespace jtx;
|
||||
Account const alice {"alice"};
|
||||
Account const bob {"bob"};
|
||||
Account const alice{"alice"};
|
||||
Account const bob{"bob"};
|
||||
|
||||
Env env (*this);
|
||||
Env env(*this);
|
||||
|
||||
env.fund (XRP (10000), alice, bob);
|
||||
env.fund(XRP(10000), alice, bob);
|
||||
|
||||
// bob sets the lsfDepositAuth flag.
|
||||
env (fset (bob, asfDepositAuth), fee (drops (10)));
|
||||
env(fset(bob, asfDepositAuth), fee(drops(10)));
|
||||
env.close();
|
||||
BEAST_EXPECT (env.balance (bob, XRP) == XRP (10000) - drops(10));
|
||||
BEAST_EXPECT(env.balance(bob, XRP) == XRP(10000) - drops(10));
|
||||
|
||||
// bob has more XRP than the base reserve. Any XRP payment should fail.
|
||||
env (pay (alice, bob, drops(1)), ter (tecNO_PERMISSION));
|
||||
env(pay(alice, bob, drops(1)), ter(tecNO_PERMISSION));
|
||||
env.close();
|
||||
BEAST_EXPECT (env.balance (bob, XRP) == XRP (10000) - drops(10));
|
||||
BEAST_EXPECT(env.balance(bob, XRP) == XRP(10000) - drops(10));
|
||||
|
||||
// Change bob's XRP balance to exactly the base reserve.
|
||||
{
|
||||
STAmount const bobPaysXRP {
|
||||
env.balance (bob, XRP) - reserve (env, 1)};
|
||||
XRPAmount const bobPaysFee {reserve (env, 1) - reserve (env, 0)};
|
||||
env (pay (bob, alice, bobPaysXRP), fee (bobPaysFee));
|
||||
STAmount const bobPaysXRP{env.balance(bob, XRP) - reserve(env, 1)};
|
||||
XRPAmount const bobPaysFee{reserve(env, 1) - reserve(env, 0)};
|
||||
env(pay(bob, alice, bobPaysXRP), fee(bobPaysFee));
|
||||
env.close();
|
||||
}
|
||||
|
||||
// bob has exactly the base reserve. A small enough direct XRP
|
||||
// payment should succeed.
|
||||
BEAST_EXPECT (env.balance (bob, XRP) == reserve (env, 0));
|
||||
env (pay (alice, bob, drops(1)));
|
||||
BEAST_EXPECT(env.balance(bob, XRP) == reserve(env, 0));
|
||||
env(pay(alice, bob, drops(1)));
|
||||
env.close();
|
||||
|
||||
// bob has exactly the base reserve + 1. No payment should succeed.
|
||||
BEAST_EXPECT (env.balance (bob, XRP) == reserve (env, 0) + drops(1));
|
||||
env (pay (alice, bob, drops(1)), ter (tecNO_PERMISSION));
|
||||
BEAST_EXPECT(env.balance(bob, XRP) == reserve(env, 0) + drops(1));
|
||||
env(pay(alice, bob, drops(1)), ter(tecNO_PERMISSION));
|
||||
env.close();
|
||||
|
||||
// Take bob down to a balance of 0 XRP.
|
||||
env (noop (bob), fee (reserve (env, 0) + drops(1)));
|
||||
env.close ();
|
||||
BEAST_EXPECT (env.balance (bob, XRP) == drops(0));
|
||||
env(noop(bob), fee(reserve(env, 0) + drops(1)));
|
||||
env.close();
|
||||
BEAST_EXPECT(env.balance(bob, XRP) == drops(0));
|
||||
|
||||
// We should not be able to pay bob more than the base reserve.
|
||||
env (pay (alice, bob, reserve (env, 0) + drops(1)),
|
||||
ter (tecNO_PERMISSION));
|
||||
env(pay(alice, bob, reserve(env, 0) + drops(1)), ter(tecNO_PERMISSION));
|
||||
env.close();
|
||||
|
||||
// However a payment of exactly the base reserve should succeed.
|
||||
env (pay (alice, bob, reserve (env, 0) + drops(0)));
|
||||
env(pay(alice, bob, reserve(env, 0) + drops(0)));
|
||||
env.close();
|
||||
BEAST_EXPECT (env.balance (bob, XRP) == reserve (env, 0));
|
||||
BEAST_EXPECT(env.balance(bob, XRP) == reserve(env, 0));
|
||||
|
||||
// We should be able to pay bob the base reserve one more time.
|
||||
env (pay (alice, bob, reserve (env, 0) + drops(0)));
|
||||
env(pay(alice, bob, reserve(env, 0) + drops(0)));
|
||||
env.close();
|
||||
BEAST_EXPECT (env.balance (bob, XRP) ==
|
||||
(reserve (env, 0) + reserve (env, 0)));
|
||||
BEAST_EXPECT(
|
||||
env.balance(bob, XRP) == (reserve(env, 0) + reserve(env, 0)));
|
||||
|
||||
// bob's above the threshold again. Any payment should fail.
|
||||
env (pay (alice, bob, drops(1)), ter (tecNO_PERMISSION));
|
||||
env(pay(alice, bob, drops(1)), ter(tecNO_PERMISSION));
|
||||
env.close();
|
||||
BEAST_EXPECT (env.balance (bob, XRP) ==
|
||||
(reserve (env, 0) + reserve (env, 0)));
|
||||
BEAST_EXPECT(
|
||||
env.balance(bob, XRP) == (reserve(env, 0) + reserve(env, 0)));
|
||||
|
||||
// Take bob back down to a zero XRP balance.
|
||||
env (noop (bob), fee (env.balance (bob, XRP)));
|
||||
env(noop(bob), fee(env.balance(bob, XRP)));
|
||||
env.close();
|
||||
BEAST_EXPECT (env.balance (bob, XRP) == drops(0));
|
||||
BEAST_EXPECT(env.balance(bob, XRP) == drops(0));
|
||||
|
||||
// bob should not be able to clear lsfDepositAuth.
|
||||
env (fclear (bob, asfDepositAuth), ter (terINSUF_FEE_B));
|
||||
env(fclear(bob, asfDepositAuth), ter(terINSUF_FEE_B));
|
||||
env.close();
|
||||
|
||||
// We should be able to pay bob 1 drop now.
|
||||
env (pay (alice, bob, drops(1)));
|
||||
env(pay(alice, bob, drops(1)));
|
||||
env.close();
|
||||
BEAST_EXPECT (env.balance (bob, XRP) == drops(1));
|
||||
BEAST_EXPECT(env.balance(bob, XRP) == drops(1));
|
||||
|
||||
// Pay bob enough so he can afford the fee to clear lsfDepositAuth.
|
||||
env (pay (alice, bob, drops(9)));
|
||||
env(pay(alice, bob, drops(9)));
|
||||
env.close();
|
||||
|
||||
// Interestingly, at this point the terINSUF_FEE_B retry grabs the
|
||||
// request to clear lsfDepositAuth. So the balance should be zero
|
||||
// and lsfDepositAuth should be cleared.
|
||||
BEAST_EXPECT (env.balance (bob, XRP) == drops(0));
|
||||
env.require (nflags (bob, asfDepositAuth));
|
||||
BEAST_EXPECT(env.balance(bob, XRP) == drops(0));
|
||||
env.require(nflags(bob, asfDepositAuth));
|
||||
|
||||
// Since bob no longer has lsfDepositAuth set we should be able to
|
||||
// pay him more than the base reserve.
|
||||
env (pay (alice, bob, reserve (env, 0) + drops(1)));
|
||||
env(pay(alice, bob, reserve(env, 0) + drops(1)));
|
||||
env.close();
|
||||
BEAST_EXPECT (env.balance (bob, XRP) == reserve (env, 0) + drops(1));
|
||||
BEAST_EXPECT(env.balance(bob, XRP) == reserve(env, 0) + drops(1));
|
||||
}
|
||||
|
||||
void testNoRipple()
|
||||
void
|
||||
testNoRipple()
|
||||
{
|
||||
// It its current incarnation the DepositAuth flag does not change
|
||||
// any behaviors regarding rippling and the NoRipple flag.
|
||||
// Demonstrate that.
|
||||
testcase ("No Ripple");
|
||||
testcase("No Ripple");
|
||||
|
||||
using namespace jtx;
|
||||
Account const gw1 ("gw1");
|
||||
Account const gw2 ("gw2");
|
||||
Account const alice ("alice");
|
||||
Account const bob ("bob");
|
||||
Account const gw1("gw1");
|
||||
Account const gw2("gw2");
|
||||
Account const alice("alice");
|
||||
Account const bob("bob");
|
||||
|
||||
IOU const USD1 (gw1["USD"]);
|
||||
IOU const USD2 (gw2["USD"]);
|
||||
IOU const USD1(gw1["USD"]);
|
||||
IOU const USD2(gw2["USD"]);
|
||||
|
||||
auto testIssuer = [&] (FeatureBitset const& features,
|
||||
bool noRipplePrev,
|
||||
bool noRippleNext,
|
||||
bool withDepositAuth)
|
||||
{
|
||||
auto testIssuer = [&](FeatureBitset const& features,
|
||||
bool noRipplePrev,
|
||||
bool noRippleNext,
|
||||
bool withDepositAuth) {
|
||||
assert(!withDepositAuth || features[featureDepositAuth]);
|
||||
|
||||
Env env(*this, features);
|
||||
|
||||
env.fund(XRP(10000), gw1, alice, bob);
|
||||
env (trust (gw1, alice["USD"](10), noRipplePrev ? tfSetNoRipple : 0));
|
||||
env (trust (gw1, bob["USD"](10), noRippleNext ? tfSetNoRipple : 0));
|
||||
env.trust(USD1 (10), alice, bob);
|
||||
env(trust(gw1, alice["USD"](10), noRipplePrev ? tfSetNoRipple : 0));
|
||||
env(trust(gw1, bob["USD"](10), noRippleNext ? tfSetNoRipple : 0));
|
||||
env.trust(USD1(10), alice, bob);
|
||||
|
||||
env(pay(gw1, alice, USD1(10)));
|
||||
|
||||
if (withDepositAuth)
|
||||
env(fset(gw1, asfDepositAuth));
|
||||
|
||||
TER const result = (noRippleNext && noRipplePrev)
|
||||
? TER {tecPATH_DRY}
|
||||
: TER {tesSUCCESS};
|
||||
env (pay (alice, bob, USD1(10)), path (gw1), ter (result));
|
||||
TER const result = (noRippleNext && noRipplePrev) ? TER{tecPATH_DRY}
|
||||
: TER{tesSUCCESS};
|
||||
env(pay(alice, bob, USD1(10)), path(gw1), ter(result));
|
||||
};
|
||||
|
||||
auto testNonIssuer = [&] (FeatureBitset const& features,
|
||||
bool noRipplePrev,
|
||||
bool noRippleNext,
|
||||
bool withDepositAuth)
|
||||
{
|
||||
auto testNonIssuer = [&](FeatureBitset const& features,
|
||||
bool noRipplePrev,
|
||||
bool noRippleNext,
|
||||
bool withDepositAuth) {
|
||||
assert(!withDepositAuth || features[featureDepositAuth]);
|
||||
|
||||
Env env(*this, features);
|
||||
|
||||
env.fund(XRP(10000), gw1, gw2, alice);
|
||||
env (trust (alice, USD1(10), noRipplePrev ? tfSetNoRipple : 0));
|
||||
env (trust (alice, USD2(10), noRippleNext ? tfSetNoRipple : 0));
|
||||
env(trust(alice, USD1(10), noRipplePrev ? tfSetNoRipple : 0));
|
||||
env(trust(alice, USD2(10), noRippleNext ? tfSetNoRipple : 0));
|
||||
env(pay(gw2, alice, USD2(10)));
|
||||
|
||||
if (withDepositAuth)
|
||||
env(fset(alice, asfDepositAuth));
|
||||
|
||||
TER const result = (noRippleNext && noRipplePrev)
|
||||
? TER {tecPATH_DRY}
|
||||
: TER {tesSUCCESS};
|
||||
env (pay (gw1, gw2, USD2 (10)),
|
||||
path (alice), sendmax (USD1 (10)), ter (result));
|
||||
TER const result = (noRippleNext && noRipplePrev) ? TER{tecPATH_DRY}
|
||||
: TER{tesSUCCESS};
|
||||
env(pay(gw1, gw2, USD2(10)),
|
||||
path(alice),
|
||||
sendmax(USD1(10)),
|
||||
ter(result));
|
||||
};
|
||||
|
||||
// Test every combo of noRipplePrev, noRippleNext, and withDepositAuth
|
||||
@@ -371,7 +371,8 @@ struct DepositAuth_test : public beast::unit_test::suite
|
||||
}
|
||||
}
|
||||
|
||||
void run() override
|
||||
void
|
||||
run() override
|
||||
{
|
||||
testEnable();
|
||||
testPayIOU();
|
||||
@@ -382,30 +383,31 @@ struct DepositAuth_test : public beast::unit_test::suite
|
||||
|
||||
struct DepositPreauth_test : public beast::unit_test::suite
|
||||
{
|
||||
void testEnable()
|
||||
void
|
||||
testEnable()
|
||||
{
|
||||
testcase ("Enable");
|
||||
testcase("Enable");
|
||||
|
||||
using namespace jtx;
|
||||
Account const alice {"alice"};
|
||||
Account const becky {"becky"};
|
||||
Account const alice{"alice"};
|
||||
Account const becky{"becky"};
|
||||
{
|
||||
// featureDepositPreauth is disabled.
|
||||
Env env (*this, supported_amendments() - featureDepositPreauth);
|
||||
env.fund (XRP (10000), alice, becky);
|
||||
Env env(*this, supported_amendments() - featureDepositPreauth);
|
||||
env.fund(XRP(10000), alice, becky);
|
||||
env.close();
|
||||
|
||||
// Should not be able to add a DepositPreauth to alice.
|
||||
env (deposit::auth (alice, becky), ter (temDISABLED));
|
||||
env(deposit::auth(alice, becky), ter(temDISABLED));
|
||||
env.close();
|
||||
env.require (owners (alice, 0));
|
||||
env.require (owners (becky, 0));
|
||||
env.require(owners(alice, 0));
|
||||
env.require(owners(becky, 0));
|
||||
|
||||
// Should not be able to remove a DepositPreauth from alice.
|
||||
env (deposit::unauth (alice, becky), ter (temDISABLED));
|
||||
env(deposit::unauth(alice, becky), ter(temDISABLED));
|
||||
env.close();
|
||||
env.require (owners (alice, 0));
|
||||
env.require (owners (becky, 0));
|
||||
env.require(owners(alice, 0));
|
||||
env.require(owners(becky, 0));
|
||||
}
|
||||
{
|
||||
// featureDepositPreauth is enabled. The valid case is really
|
||||
@@ -413,151 +415,152 @@ struct DepositPreauth_test : public beast::unit_test::suite
|
||||
// o We should be able to add and remove an entry, and
|
||||
// o That entry should cost one reserve.
|
||||
// o The reserve should be returned when the entry is removed.
|
||||
Env env (*this);
|
||||
env.fund (XRP (10000), alice, becky);
|
||||
Env env(*this);
|
||||
env.fund(XRP(10000), alice, becky);
|
||||
env.close();
|
||||
|
||||
// Add a DepositPreauth to alice.
|
||||
env (deposit::auth (alice, becky));
|
||||
env(deposit::auth(alice, becky));
|
||||
env.close();
|
||||
env.require (owners (alice, 1));
|
||||
env.require (owners (becky, 0));
|
||||
env.require(owners(alice, 1));
|
||||
env.require(owners(becky, 0));
|
||||
|
||||
// Remove a DepositPreauth from alice.
|
||||
env (deposit::unauth (alice, becky));
|
||||
env(deposit::unauth(alice, becky));
|
||||
env.close();
|
||||
env.require (owners (alice, 0));
|
||||
env.require (owners (becky, 0));
|
||||
env.require(owners(alice, 0));
|
||||
env.require(owners(becky, 0));
|
||||
}
|
||||
}
|
||||
|
||||
void testInvalid()
|
||||
void
|
||||
testInvalid()
|
||||
{
|
||||
testcase ("Invalid");
|
||||
testcase("Invalid");
|
||||
|
||||
using namespace jtx;
|
||||
Account const alice {"alice"};
|
||||
Account const becky {"becky"};
|
||||
Account const carol {"carol"};
|
||||
Account const alice{"alice"};
|
||||
Account const becky{"becky"};
|
||||
Account const carol{"carol"};
|
||||
|
||||
Env env (*this);
|
||||
Env env(*this);
|
||||
|
||||
// Tell env about alice, becky and carol since they are not yet funded.
|
||||
env.memoize (alice);
|
||||
env.memoize (becky);
|
||||
env.memoize (carol);
|
||||
env.memoize(alice);
|
||||
env.memoize(becky);
|
||||
env.memoize(carol);
|
||||
|
||||
// Add DepositPreauth to an unfunded account.
|
||||
env (deposit::auth (alice, becky), seq (1), ter (terNO_ACCOUNT));
|
||||
env(deposit::auth(alice, becky), seq(1), ter(terNO_ACCOUNT));
|
||||
|
||||
env.fund (XRP (10000), alice, becky);
|
||||
env.fund(XRP(10000), alice, becky);
|
||||
env.close();
|
||||
|
||||
// Bad fee.
|
||||
env (deposit::auth (alice, becky), fee (drops(-10)), ter (temBAD_FEE));
|
||||
env(deposit::auth(alice, becky), fee(drops(-10)), ter(temBAD_FEE));
|
||||
env.close();
|
||||
|
||||
// Bad flags.
|
||||
env (deposit::auth (alice, becky),
|
||||
txflags (tfSell), ter (temINVALID_FLAG));
|
||||
env(deposit::auth(alice, becky), txflags(tfSell), ter(temINVALID_FLAG));
|
||||
env.close();
|
||||
|
||||
{
|
||||
// Neither auth not unauth.
|
||||
Json::Value tx {deposit::auth (alice, becky)};
|
||||
tx.removeMember (sfAuthorize.jsonName);
|
||||
env (tx, ter (temMALFORMED));
|
||||
Json::Value tx{deposit::auth(alice, becky)};
|
||||
tx.removeMember(sfAuthorize.jsonName);
|
||||
env(tx, ter(temMALFORMED));
|
||||
env.close();
|
||||
}
|
||||
{
|
||||
// Both auth and unauth.
|
||||
Json::Value tx {deposit::auth (alice, becky)};
|
||||
Json::Value tx{deposit::auth(alice, becky)};
|
||||
tx[sfUnauthorize.jsonName] = becky.human();
|
||||
env (tx, ter (temMALFORMED));
|
||||
env(tx, ter(temMALFORMED));
|
||||
env.close();
|
||||
}
|
||||
{
|
||||
// Alice authorizes a zero account.
|
||||
Json::Value tx {deposit::auth (alice, becky)};
|
||||
tx[sfAuthorize.jsonName] = to_string (xrpAccount());
|
||||
env (tx, ter (temINVALID_ACCOUNT_ID));
|
||||
Json::Value tx{deposit::auth(alice, becky)};
|
||||
tx[sfAuthorize.jsonName] = to_string(xrpAccount());
|
||||
env(tx, ter(temINVALID_ACCOUNT_ID));
|
||||
env.close();
|
||||
}
|
||||
|
||||
// alice authorizes herself.
|
||||
env (deposit::auth (alice, alice), ter (temCANNOT_PREAUTH_SELF));
|
||||
env(deposit::auth(alice, alice), ter(temCANNOT_PREAUTH_SELF));
|
||||
env.close();
|
||||
|
||||
// alice authorizes an unfunded account.
|
||||
env (deposit::auth (alice, carol), ter (tecNO_TARGET));
|
||||
env(deposit::auth(alice, carol), ter(tecNO_TARGET));
|
||||
env.close();
|
||||
|
||||
// alice successfully authorizes becky.
|
||||
env.require (owners (alice, 0));
|
||||
env.require (owners (becky, 0));
|
||||
env (deposit::auth (alice, becky));
|
||||
env.require(owners(alice, 0));
|
||||
env.require(owners(becky, 0));
|
||||
env(deposit::auth(alice, becky));
|
||||
env.close();
|
||||
env.require (owners (alice, 1));
|
||||
env.require (owners (becky, 0));
|
||||
env.require(owners(alice, 1));
|
||||
env.require(owners(becky, 0));
|
||||
|
||||
// alice attempts to create a duplicate authorization.
|
||||
env (deposit::auth (alice, becky), ter (tecDUPLICATE));
|
||||
env(deposit::auth(alice, becky), ter(tecDUPLICATE));
|
||||
env.close();
|
||||
env.require (owners (alice, 1));
|
||||
env.require (owners (becky, 0));
|
||||
env.require(owners(alice, 1));
|
||||
env.require(owners(becky, 0));
|
||||
|
||||
// carol attempts to preauthorize but doesn't have enough reserve.
|
||||
env.fund (drops (249'999'999), carol);
|
||||
env.fund(drops(249'999'999), carol);
|
||||
env.close();
|
||||
|
||||
env (deposit::auth (carol, becky), ter (tecINSUFFICIENT_RESERVE));
|
||||
env(deposit::auth(carol, becky), ter(tecINSUFFICIENT_RESERVE));
|
||||
env.close();
|
||||
env.require (owners (carol, 0));
|
||||
env.require (owners (becky, 0));
|
||||
env.require(owners(carol, 0));
|
||||
env.require(owners(becky, 0));
|
||||
|
||||
// carol gets enough XRP to (barely) meet the reserve.
|
||||
env (pay (alice, carol, drops (11)));
|
||||
env(pay(alice, carol, drops(11)));
|
||||
env.close();
|
||||
env (deposit::auth (carol, becky));
|
||||
env(deposit::auth(carol, becky));
|
||||
env.close();
|
||||
env.require (owners (carol, 1));
|
||||
env.require (owners (becky, 0));
|
||||
env.require(owners(carol, 1));
|
||||
env.require(owners(becky, 0));
|
||||
|
||||
// But carol can't meet the reserve for another preauthorization.
|
||||
env (deposit::auth (carol, alice), ter (tecINSUFFICIENT_RESERVE));
|
||||
env(deposit::auth(carol, alice), ter(tecINSUFFICIENT_RESERVE));
|
||||
env.close();
|
||||
env.require (owners (carol, 1));
|
||||
env.require (owners (becky, 0));
|
||||
env.require (owners (alice, 1));
|
||||
env.require(owners(carol, 1));
|
||||
env.require(owners(becky, 0));
|
||||
env.require(owners(alice, 1));
|
||||
|
||||
// alice attempts to remove an authorization she doesn't have.
|
||||
env (deposit::unauth (alice, carol), ter (tecNO_ENTRY));
|
||||
env(deposit::unauth(alice, carol), ter(tecNO_ENTRY));
|
||||
env.close();
|
||||
env.require (owners (alice, 1));
|
||||
env.require (owners (becky, 0));
|
||||
env.require(owners(alice, 1));
|
||||
env.require(owners(becky, 0));
|
||||
|
||||
// alice successfully removes her authorization of becky.
|
||||
env (deposit::unauth (alice, becky));
|
||||
env(deposit::unauth(alice, becky));
|
||||
env.close();
|
||||
env.require (owners (alice, 0));
|
||||
env.require (owners (becky, 0));
|
||||
env.require(owners(alice, 0));
|
||||
env.require(owners(becky, 0));
|
||||
|
||||
// alice removes becky again and gets an error.
|
||||
env (deposit::unauth (alice, becky), ter (tecNO_ENTRY));
|
||||
env(deposit::unauth(alice, becky), ter(tecNO_ENTRY));
|
||||
env.close();
|
||||
env.require (owners (alice, 0));
|
||||
env.require (owners (becky, 0));
|
||||
env.require(owners(alice, 0));
|
||||
env.require(owners(becky, 0));
|
||||
}
|
||||
|
||||
void testPayment (FeatureBitset features)
|
||||
void
|
||||
testPayment(FeatureBitset features)
|
||||
{
|
||||
testcase ("Payment");
|
||||
testcase("Payment");
|
||||
|
||||
using namespace jtx;
|
||||
Account const alice {"alice"};
|
||||
Account const becky {"becky"};
|
||||
Account const gw {"gw"};
|
||||
IOU const USD (gw["USD"]);
|
||||
Account const alice{"alice"};
|
||||
Account const becky{"becky"};
|
||||
Account const gw{"gw"};
|
||||
IOU const USD(gw["USD"]);
|
||||
|
||||
bool const supportsPreauth = {features[featureDepositPreauth]};
|
||||
|
||||
@@ -565,38 +568,39 @@ struct DepositPreauth_test : public beast::unit_test::suite
|
||||
// The initial implementation of DepositAuth had a bug where an
|
||||
// account with the DepositAuth flag set could not make a payment
|
||||
// to itself. That bug was fixed in the DepositPreauth amendment.
|
||||
Env env (*this, features);
|
||||
env.fund (XRP (5000), alice, becky, gw);
|
||||
Env env(*this, features);
|
||||
env.fund(XRP(5000), alice, becky, gw);
|
||||
env.close();
|
||||
|
||||
env.trust (USD (1000), alice);
|
||||
env.trust (USD (1000), becky);
|
||||
env.trust(USD(1000), alice);
|
||||
env.trust(USD(1000), becky);
|
||||
env.close();
|
||||
|
||||
env (pay (gw, alice, USD (500)));
|
||||
env(pay(gw, alice, USD(500)));
|
||||
env.close();
|
||||
|
||||
env (offer (alice, XRP (100), USD (100), tfPassive),
|
||||
require (offers (alice, 1)));
|
||||
env(offer(alice, XRP(100), USD(100), tfPassive),
|
||||
require(offers(alice, 1)));
|
||||
env.close();
|
||||
|
||||
// becky pays herself USD (10) by consuming part of alice's offer.
|
||||
// Make sure the payment works if PaymentAuth is not involved.
|
||||
env (pay (becky, becky, USD (10)),
|
||||
path (~USD), sendmax (XRP (10)));
|
||||
env(pay(becky, becky, USD(10)), path(~USD), sendmax(XRP(10)));
|
||||
env.close();
|
||||
|
||||
// becky decides to require authorization for deposits.
|
||||
env(fset (becky, asfDepositAuth));
|
||||
env(fset(becky, asfDepositAuth));
|
||||
env.close();
|
||||
|
||||
// becky pays herself again. Whether it succeeds depends on
|
||||
// whether featureDepositPreauth is enabled.
|
||||
TER const expect {
|
||||
supportsPreauth ? TER {tesSUCCESS} : TER {tecNO_PERMISSION}};
|
||||
TER const expect{
|
||||
supportsPreauth ? TER{tesSUCCESS} : TER{tecNO_PERMISSION}};
|
||||
|
||||
env (pay (becky, becky, USD (10)),
|
||||
path (~USD), sendmax (XRP (10)), ter (expect));
|
||||
env(pay(becky, becky, USD(10)),
|
||||
path(~USD),
|
||||
sendmax(XRP(10)),
|
||||
ter(expect));
|
||||
env.close();
|
||||
}
|
||||
|
||||
@@ -604,101 +608,102 @@ struct DepositPreauth_test : public beast::unit_test::suite
|
||||
{
|
||||
// Make sure DepositPreauthorization works for payments.
|
||||
|
||||
Account const carol {"carol"};
|
||||
Account const carol{"carol"};
|
||||
|
||||
Env env (*this, features);
|
||||
env.fund (XRP (5000), alice, becky, carol, gw);
|
||||
Env env(*this, features);
|
||||
env.fund(XRP(5000), alice, becky, carol, gw);
|
||||
env.close();
|
||||
|
||||
env.trust (USD (1000), alice);
|
||||
env.trust (USD (1000), becky);
|
||||
env.trust (USD (1000), carol);
|
||||
env.trust(USD(1000), alice);
|
||||
env.trust(USD(1000), becky);
|
||||
env.trust(USD(1000), carol);
|
||||
env.close();
|
||||
|
||||
env (pay (gw, alice, USD (1000)));
|
||||
env(pay(gw, alice, USD(1000)));
|
||||
env.close();
|
||||
|
||||
// Make XRP and IOU payments from alice to becky. Should be fine.
|
||||
env (pay (alice, becky, XRP (100)));
|
||||
env (pay (alice, becky, USD (100)));
|
||||
env(pay(alice, becky, XRP(100)));
|
||||
env(pay(alice, becky, USD(100)));
|
||||
env.close();
|
||||
|
||||
// becky decides to require authorization for deposits.
|
||||
env(fset (becky, asfDepositAuth));
|
||||
env(fset(becky, asfDepositAuth));
|
||||
env.close();
|
||||
|
||||
// alice can no longer pay becky.
|
||||
env (pay (alice, becky, XRP (100)), ter (tecNO_PERMISSION));
|
||||
env (pay (alice, becky, USD (100)), ter (tecNO_PERMISSION));
|
||||
env(pay(alice, becky, XRP(100)), ter(tecNO_PERMISSION));
|
||||
env(pay(alice, becky, USD(100)), ter(tecNO_PERMISSION));
|
||||
env.close();
|
||||
|
||||
// becky preauthorizes carol for deposit, which doesn't provide
|
||||
// authorization for alice.
|
||||
env (deposit::auth (becky, carol));
|
||||
env(deposit::auth(becky, carol));
|
||||
env.close();
|
||||
|
||||
// alice still can't pay becky.
|
||||
env (pay (alice, becky, XRP (100)), ter (tecNO_PERMISSION));
|
||||
env (pay (alice, becky, USD (100)), ter (tecNO_PERMISSION));
|
||||
env(pay(alice, becky, XRP(100)), ter(tecNO_PERMISSION));
|
||||
env(pay(alice, becky, USD(100)), ter(tecNO_PERMISSION));
|
||||
env.close();
|
||||
|
||||
// becky preauthorizes alice for deposit.
|
||||
env (deposit::auth (becky, alice));
|
||||
env(deposit::auth(becky, alice));
|
||||
env.close();
|
||||
|
||||
// alice can now pay becky.
|
||||
env (pay (alice, becky, XRP (100)));
|
||||
env (pay (alice, becky, USD (100)));
|
||||
env(pay(alice, becky, XRP(100)));
|
||||
env(pay(alice, becky, USD(100)));
|
||||
env.close();
|
||||
|
||||
// alice decides to require authorization for deposits.
|
||||
env(fset (alice, asfDepositAuth));
|
||||
env(fset(alice, asfDepositAuth));
|
||||
env.close();
|
||||
|
||||
// Even though alice is authorized to pay becky, becky is not
|
||||
// authorized to pay alice.
|
||||
env (pay (becky, alice, XRP (100)), ter (tecNO_PERMISSION));
|
||||
env (pay (becky, alice, USD (100)), ter (tecNO_PERMISSION));
|
||||
env(pay(becky, alice, XRP(100)), ter(tecNO_PERMISSION));
|
||||
env(pay(becky, alice, USD(100)), ter(tecNO_PERMISSION));
|
||||
env.close();
|
||||
|
||||
// becky unauthorizes carol. Should have no impact on alice.
|
||||
env (deposit::unauth (becky, carol));
|
||||
env(deposit::unauth(becky, carol));
|
||||
env.close();
|
||||
|
||||
env (pay (alice, becky, XRP (100)));
|
||||
env (pay (alice, becky, USD (100)));
|
||||
env(pay(alice, becky, XRP(100)));
|
||||
env(pay(alice, becky, USD(100)));
|
||||
env.close();
|
||||
|
||||
// becky unauthorizes alice. alice now can't pay becky.
|
||||
env (deposit::unauth (becky, alice));
|
||||
env(deposit::unauth(becky, alice));
|
||||
env.close();
|
||||
|
||||
env (pay (alice, becky, XRP (100)), ter (tecNO_PERMISSION));
|
||||
env (pay (alice, becky, USD (100)), ter (tecNO_PERMISSION));
|
||||
env(pay(alice, becky, XRP(100)), ter(tecNO_PERMISSION));
|
||||
env(pay(alice, becky, USD(100)), ter(tecNO_PERMISSION));
|
||||
env.close();
|
||||
|
||||
// becky decides to remove authorization for deposits. Now
|
||||
// alice can pay becky again.
|
||||
env(fclear (becky, asfDepositAuth));
|
||||
env(fclear(becky, asfDepositAuth));
|
||||
env.close();
|
||||
|
||||
env (pay (alice, becky, XRP (100)));
|
||||
env (pay (alice, becky, USD (100)));
|
||||
env(pay(alice, becky, XRP(100)));
|
||||
env(pay(alice, becky, USD(100)));
|
||||
env.close();
|
||||
}
|
||||
}
|
||||
|
||||
void run() override
|
||||
void
|
||||
run() override
|
||||
{
|
||||
testEnable();
|
||||
testInvalid();
|
||||
testPayment (jtx::supported_amendments() - featureDepositPreauth);
|
||||
testPayment (jtx::supported_amendments());
|
||||
testPayment(jtx::supported_amendments() - featureDepositPreauth);
|
||||
testPayment(jtx::supported_amendments());
|
||||
}
|
||||
};
|
||||
|
||||
BEAST_DEFINE_TESTSUITE(DepositAuth,app,ripple);
|
||||
BEAST_DEFINE_TESTSUITE(DepositPreauth,app,ripple);
|
||||
BEAST_DEFINE_TESTSUITE(DepositAuth, app, ripple);
|
||||
BEAST_DEFINE_TESTSUITE(DepositPreauth, app, ripple);
|
||||
|
||||
} // test
|
||||
} // ripple
|
||||
} // namespace test
|
||||
} // namespace ripple
|
||||
|
||||
Reference in New Issue
Block a user