ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-02 17:06:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

disallow a computation allowance of 0 (#5541)

Browse Source
This commit is contained in:
Mayukha Vadari
2025-07-09 00:34:17 +05:30
committed by GitHub
parent 7bdf5fa8b8
commit 4fa0ae521e
2 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/test/app/Escrow_test.cpp
View File

@@ -1970,6 +1970,13 @@ struct Escrow_test : public beast::unit_test::suite
ter(tefWASM_FIELD_NOT_INCLUDED)); ter(tefWASM_FIELD_NOT_INCLUDED));
} }
{
// ComputationAllowance value of 0
env(escrow::finish(carol, alice, seq),
escrow::comp_allowance(0),
ter(temBAD_LIMIT));
}
{ {
// not enough fees // not enough fees
// This function takes 4 gas // This function takes 4 gas

4
src/xrpld/app/tx/detail/Escrow.cpp
View File

@@ -743,6 +743,10 @@ EscrowFinish::preflight(PreflightContext const& ctx)
if (auto const allowance = ctx.tx[~sfComputationAllowance]; allowance) if (auto const allowance = ctx.tx[~sfComputationAllowance]; allowance)
{ {
if (*allowance == 0)
{
return temBAD_LIMIT;
}
if (*allowance > ctx.app.config().FEES.extension_compute_limit) if (*allowance > ctx.app.config().FEES.extension_compute_limit)
{ {
JLOG(ctx.j.debug()) JLOG(ctx.j.debug())