diff --git a/OpenTelemetryPlan/09-data-collection-reference.md b/OpenTelemetryPlan/09-data-collection-reference.md index 5b4026e6e6..55b3735acc 100644 --- a/OpenTelemetryPlan/09-data-collection-reference.md +++ b/OpenTelemetryPlan/09-data-collection-reference.md @@ -326,7 +326,6 @@ The tables below list one row per attribute per subsystem, so a key shared by tw | `tx_type` | string | `tx.process`, `tx.preflight`, `tx.preclaim`, `tx.transactor` | Transaction type name (e.g., `Payment`) | | `fee` | int64 | `tx.process` | Transaction fee in drops | | `sequence` | int64 | `tx.process` | Transaction sequence number | -| `suppressed` | boolean | `tx.receive` | `true` if transaction was suppressed (duplicate) | | `tx_status` | string | `tx.receive` | Transaction status (e.g., `"known_bad"`) | | `peer_id` | int64 | `tx.receive` | Peer identifier (also set on peer spans) | | `peer_version` | string | `tx.receive` | Peer protocol version string | diff --git a/OpenTelemetryPlan/Phase3_taskList.md b/OpenTelemetryPlan/Phase3_taskList.md index 613e8008f8..00ee2fd725 100644 --- a/OpenTelemetryPlan/Phase3_taskList.md +++ b/OpenTelemetryPlan/Phase3_taskList.md @@ -90,7 +90,7 @@ - Extract parent trace context from incoming `TMTransaction::trace_context` field (if present) - Create `tx.receive` span as child of extracted context (or new root if none) - Set attributes: `tx_hash`, `peer_id`, `tx_status` - - On HashRouter suppression (duplicate): set `suppressed=true`, add `tx.duplicate` event + - Create the span only after `HashRouter::shouldProcess()` accepts, so a dropped duplicate produces no span - Wrap validation call with child span `tx.validate` - Wrap relay with `tx.relay` span - When relaying to peers: @@ -159,7 +159,7 @@ - Edit `src/xrpld/overlay/detail/PeerImp.cpp` (in handleTransaction): - After calling `HashRouter::shouldProcess()` or `addSuppressionPeer()`: - - Record `suppressed` attribute (true/false) + - Start the span here, not before, so only transactions this node will process are traced - Record `tx_flags` showing current HashRouter state (SAVED, TRUSTED, etc.) - Add `tx.first_seen` or `tx.duplicate` event @@ -373,7 +373,7 @@ This gives the best of both worlds: guaranteed cross-node correlation via determ **combine** with deterministic trace_id — use the protobuf span_id as parent to preserve relay ordering, but override trace_id with the deterministic one. 4. If no protobuf context: create span under `detCtx` directly. - 5. Set all existing attributes (`hash`, `peerId`, `peerVersion`, `suppressed`, etc.). + 5. Set all existing attributes (`hash`, `peerId`, `peerVersion`, etc.). - **Combining deterministic trace_id with protobuf parent span_id**: When both are available, construct a synthetic `SpanContext` with: