From 4d7173b5d989a8da8db5d92bb8791387b64f6746 Mon Sep 17 00:00:00 2001 From: Valon Mamudi Date: Tue, 12 Aug 2025 17:37:21 +0200 Subject: [PATCH] Mark nudb_block_size as experimental in configuration documentation Add clear warning that nudb_block_size is an experimental feature that may affect database performance and stability, as suggested in code review. --- cfg/rippled-example.cfg | 6 +++++- src/test/nodestore/NuDBFactory_test.cpp | 2 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/cfg/rippled-example.cfg b/cfg/rippled-example.cfg index 2146b93506..54198e07db 100644 --- a/cfg/rippled-example.cfg +++ b/cfg/rippled-example.cfg @@ -977,10 +977,14 @@ # # Optional keys for NuDB only: # -# nudb_block_size Block size in bytes for NuDB storage. +# nudb_block_size EXPERIMENTAL: Block size in bytes for NuDB storage. # Must be a power of 2 between 4096 and 32768. # Default is 4096. # +# WARNING: This is an experimental feature that may +# affect database performance and stability. Use with +# caution in production environments. +# # This parameter controls the fundamental storage unit # size for NuDB's internal data structures. The choice # of block size can significantly impact performance diff --git a/src/test/nodestore/NuDBFactory_test.cpp b/src/test/nodestore/NuDBFactory_test.cpp index 634f194201..de865c492f 100644 --- a/src/test/nodestore/NuDBFactory_test.cpp +++ b/src/test/nodestore/NuDBFactory_test.cpp @@ -92,7 +92,7 @@ private: // Helper function to test log messages void - testLogMessage(Section const& params, beast::severities::Level level, + testLogMessage(Section const& params, beast::severities::Severity level, std::string const& expectedMessage) { test::StreamSink sink(level);