From 3b60a190de9e02cfd8737aebf3b8547224fc18a8 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Fri, 18 Sep 2026 09:32:29 +0100 Subject: [PATCH] fix(telemetry): drop the remaining suppressed dimensions and diagram values Alloy and the Grafana Cloud collector still declared a spanmetrics dimension for an attribute tx.receive no longer sets, which only widens the label set. The runbook's drop-path diagram still listed two tx_status values that no longer exist, because the paths that set them now run before the span starts. --- docker/telemetry/alloy/config.alloy | 1 - docker/telemetry/otel-collector-config.grafanacloud.yaml | 1 - docs/telemetry-runbook.md | 2 +- 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/docker/telemetry/alloy/config.alloy b/docker/telemetry/alloy/config.alloy index 3135b6149a..e5d5f613de 100644 --- a/docker/telemetry/alloy/config.alloy +++ b/docker/telemetry/alloy/config.alloy @@ -349,7 +349,6 @@ otelcol.connector.spanmetrics "xrpld" { // Overlay / peer dimensions. dimension { name = "local" } - dimension { name = "suppressed" } dimension { name = "proposal_trusted" } dimension { name = "validation_trusted" } diff --git a/docker/telemetry/otel-collector-config.grafanacloud.yaml b/docker/telemetry/otel-collector-config.grafanacloud.yaml index 21ea1804c7..01722e383a 100644 --- a/docker/telemetry/otel-collector-config.grafanacloud.yaml +++ b/docker/telemetry/otel-collector-config.grafanacloud.yaml @@ -223,7 +223,6 @@ connectors: - name: close_time_correct - name: consensus_state - name: local - - name: suppressed - name: proposal_trusted - name: validation_trusted - name: tx_type diff --git a/docs/telemetry-runbook.md b/docs/telemetry-runbook.md index ea56ec3d5f..0f8b527f36 100644 --- a/docs/telemetry-runbook.md +++ b/docs/telemetry-runbook.md @@ -588,7 +588,7 @@ flowchart TB RELAYOUT(["Overlay::relay fan-out to N peers
(no span; if applied / terQUEUED,
shouldRelay, not tfInnerBatchTxn)"]):::plain PREDROP(["Diverged / needNetworkLedger
(no span — dropped before tx.receive)"]):::drop RCV["tx.receive
(peer TMTransaction in)"]:::span - RCVDROP["tx.receive
tx_status = rejected_inner_batch /
suppressed / dropped_no_sync /
dropped_queue_full"]:::drop + RCVDROP["tx.receive
tx_status = dropped_no_sync /
dropped_queue_full"]:::drop CHK(["checkTransaction
(JtTransaction worker, no span)"]):::plain PRELAY_IN(["TMTransaction in (no span)"]):::plain